-
Notifications
You must be signed in to change notification settings - Fork 327
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Add Moco 3D tracking example with foot-ground contact #4008
Draft
nickbianco
wants to merge
23
commits into
main
Choose a base branch
from
example_3d_walking
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…p Moco problem to create initial guess
…dd other minor fixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #3960
Brief summary of changes
This change adds
example3DWalking.cpp
, an example that demonstrates how to create a simulation of walking tracking both kinematics and ground reaction forces using a contact model. This example lives inside theexample3DWalking
folder and relies on the existing reference data there, some of which was modified to accommodate the new example while still working forexampleMocoInverse
andexampleMocoTrack
. New reference files were added to allow adding contact forces to the model and for loading in marker weights based on anIKTaskSet
.The following minor additions are included in this PR which are incorporated in the new/updated examples:
ModelFactory::createResidualActuators
andModOpAddResiduals
to make it easy to add a set of residual actuators to a model.ModelFactory::createReserveActuators
andModOpAddReserves
with changes that make them compatible with the new residual utility methods.MocoTrack
to allow setting marker weights from aSet<MarkerWeight>
orIKTaskSet
.const
-qualifier toIKTaskSet::createMarkerWeightSet
.exampleMocoInverse
andexampleMocoTrack
based on the updated reference data and the new utility methods.Testing I've completed
WIP: testing all updated examples to make sure results are consistent across C++, Python, and Matlab.
Looking for feedback on...
I tried to check carefully that all updated examples are consistent with each other, but additional spot checking during review would be helpful.
CHANGELOG.md (choose one)
This change is