Skip normalization options + add variations for BN-NL part of N-Best corpus #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
greenw0lf
commented
Nov 20, 2023
greenw0lf
commented
- Added variations based on the top 20 confusion pairs noticed for the BN-NL subset
- apostrophe (') and dash (-) no longer removed when normalizing the reference and hypothesis files
- Added the option to skip normalization either for the reference or the hypothesis files (or both). For both interface and terminal options
- Added the -D flag to the sclite command in the pipeline in order to treat optional words differently (the words that are in between brackets in the reference file(s))
- Fixed a small typo in the interface (Hypothese -> Hypothesis)
Fixed a bunch of bugs and connected functionality to interface
…h-apostrophe Remove ' and - from the punctuations to be removed
…ions Add some variations + remove dash (-) again
…ions Add variation + add back dash (-) to punctuation exceptions
Fix variation bug
Add support for skipping normalization in pipeline
…-flag Add sclite -D flag for optional words
…interf Testing skip normalization in interface
…interf Test the interface when submitting the form
…interf More UI testing
…interf Hopefully last UI changes
…interf More UI testing
…interf Skip norm interf
…interf Final interface touches (hopefully)
…interf Fix issue with getting values from form submit
…interf Hopefully works this time (changed value to name)
…variations Add variations from top 20 confusion pairs
…variations One final variation
Test removing -m hyp from sclite command in pipeline
add a flag that gives a more detailed breakdown
Add another variation for Moszkowicz
KleinRana
requested changes
Feb 22, 2024
Changes include: - Changing nargs for hypfile and reffile args - Small rewording of comments and help messages - Removing skip_normalization as it was redundant - Changing the way interactive behaves (have it be a True value in the code when used) - Change normalization of numbers slightly (add a space after duizend, this is how it's done for Dutch) - Reorder sclite and variation related LOCs - Update README with new arguments added
|
I'm done with all the changes now. I decided not to add an argument for extra sclite arguments as there would be only a handful that would really work with the already-existing flags. We can add it if there will be other users requesting it. |
|
And please do test the interface/CLI, I will do some testing myself but I might miss some aspects |
KleinRana
approved these changes
Apr 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.