Migrate Designate Operator to uwsgi #334
Conversation
mod_wsgi is being removed from upstream sources but OpenStack APIs are still using it downstream, which is very concerning. This patch aims to replace mod_wsgi with uwsgi. Depends-On: openstack-k8s-operators/tcib#282
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: omersch381 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/recheck |
|
/test all |
| @@ -39,3 +39,6 @@ done | |||
| # NOTE:dkehn - REMOVED because Kolla_set & start copy eveyrthing. | |||
| # I'm doing this to get the designate.conf w/all the tags with values. | |||
| cp -a ${SVC_CFG_MERGED} ${SVC_CFG} | |||
|
|
|||
| echo "Starting Apache" | |||
| /usr/sbin/httpd -DFOREGROUND & | |||
There was a problem hiding this comment.
The init container is not the appropriate place to run this. What your probably want to do is add another kolla for starting the httpd server and it to the pod template spec for the deployment. For an example, Octavia runs multiple containers (httpd and the provider agent) in the octaviaapi deployment.
| WSGIDaemonProcess {{ $endpt }} processes=5 threads=1 user=designate group=designate display-name={{ $endpt }} | ||
| WSGIScriptAlias / "/usr/bin/designate-api-wsgi" | ||
| # ProxyPass configuration for uwsgi | ||
| ProxyPass "/dns" "http://127.0.0.1:60053" retry=0 |
There was a problem hiding this comment.
I would recommend adding "acquire=1" here.
|
Thank you guys for the comments. I will apply those if we decide eventually we continue with this direction (UWSGI). |
|
/retest all |
|
@omersch381: The Use In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/test all |
|
@omersch381: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
mod_wsgi is being removed from upstream sources but OpenStack APIs are still using it downstream, which is very concerning.
This patch aims to replace mod_wsgi with uwsgi.
Depends-On: openstack-k8s-operators/tcib#282