Rabbitmq vhost and user support by lmiccini · Pull Request #661 · openstack-k8s-operators/ironic-operator

lmiccini · 2025-12-18T12:41:48Z

Add support for a dedicated rabbitmq cluster for notifications.

Add new messagingBus and notificationsBus interfaces to hold cluster, user and vhost names for optional usage.
The controller adds these values to the TransportURL create request when present.

Additionally, we migrate RabbitMQ cluster name to RabbitMq config struct using DefaultRabbitMqConfig from infra-operator to automatically populate the new Cluster field from legacy RabbitMqClusterName.

Example usage:

  spec:
    messagingBus:
      cluster: rpc-rabbitmq
      user: rpc-user
      vhost: rpc-vhost
    notificationsBus:
      cluster: notifications-rabbitmq
      user: notifications-user
      vhost: notifications-vhost

Jira: https://issues.redhat.com/browse/OSPRH-23819

Depends-on: openstack-k8s-operators/openstack-operator#1797

Checklist before requesting a review

I have performed a self-review of my code and confirmed it passes tests
Performed pre-commit run --all
Tested operator image in a test/dev environment. It can be CRC via install_yamls or a hotstack instance (optional)
Verified that no failures present in logs(optional):
- ironic-operator-build-deploy-kuttl
- podified-multinode-ironic-deployment

softwarefactory-project-zuul · 2026-01-19T10:40:20Z

Merge Failed.

This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset.
Warning:
Error merging github.com/openstack-k8s-operators/ironic-operator for 661,e758a1e7efe54be3cf16fcbf8cb35e32ab5b5239

softwarefactory-project-zuul · 2026-01-22T09:22:59Z

This change depends on a change that failed to merge.

Change openstack-k8s-operators/infra-operator#523 is needed.

softwarefactory-project-zuul · 2026-01-26T09:50:27Z

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/4abb83ae60334914a602b1f65b84bf5b

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 06m 34s
❌ podified-multinode-ironic-deployment FAILURE in 46m 06s

softwarefactory-project-zuul · 2026-01-26T12:43:39Z

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/33f4651ad8ab4dd893b171346d711ae5

❌ openstack-k8s-operators-content-provider FAILURE in 18m 30s
⚠️ podified-multinode-ironic-deployment SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider

lmiccini · 2026-01-26T21:57:21Z

recheck

juliakreger · 2026-02-02T17:59:04Z

internal/webhook/v1beta1/ironicneutronagent_webhook.go

@@ -0,0 +1,75 @@
+/*
+Copyright 2025.


Uhh, might as well remove line 2, or put a company name or something.

steveb · 2026-02-02T19:21:53Z

api/bases/ironic.openstack.org_ironicinspectors.yaml

+                    description: Vhost - RabbitMQ vhost name
+                    type: string
+                required:
+                - cluster


The schema checker is flagging this:
ERROR: "NoNewRequiredFields": crd/ironicinspectors.ironic.openstack.org version/v1beta1 field/^.spec.messagingBus.cluster is new and may not be required
ERROR: "NoNewRequiredFields": crd/ironicinspectors.ironic.openstack.org version/v1beta1 field/^.spec.notificationsBus.cluster is new and may not be required

That's expected, we are swapping a required field - rabbitMqClusterName - with its replacement, same with NotificationsBusInstance. This will require overriding the schema checker (not just for ironic but all operators).

steveb · 2026-02-03T03:27:09Z

test/functional/ironic_webhook_test.go

+	"k8s.io/apimachinery/pkg/types"
+	"sigs.k8s.io/controller-runtime/pkg/controller/controllerutil"
+)
+


Can you please describe what the intended create behaviour is when they use a deprecated field? Will the webhook populate the new notificationBus.cluster or will it fail with an error? Whichever it is, it would be ideal to have a test for that here.

It might just need an extra assert below that demonstrates notificationBus.cluster equals "rabbitmq"

Existing ironic crs will have their rabbitMqClusterName transparently translated into messagingBus.Cluster via openstack-operator (see depends-on pr openstack-k8s-operators/openstack-operator#1779), further updates will raise an error and ask to use the new interface.

steveb · 2026-02-03T03:35:08Z

golangci-lint-full is failing with a few nits. I have restored the checklist in the PR description and I suspect that running pre-commit run --all might pick up on some of these so they can be fixed before pushing again

steveb

See inline and my other comment

softwarefactory-project-zuul · 2026-02-03T06:47:14Z

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/7fe405b399a44c49aff0c569a620b8c2

❌ openstack-k8s-operators-content-provider FAILURE in 12m 33s
⚠️ podified-multinode-ironic-deployment SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider

lmiccini · 2026-02-03T06:47:17Z

golangci-lint-full is failing with a few nits. I have restored the checklist in the PR description and I suspect that running pre-commit run --all might pick up on some of these so they can be fixed before pushing again

Thanks Steve, I should have addressed the lint errors.

lmiccini · 2026-02-03T06:47:32Z

recheck

internal/controller/ironic_controller.go

Add support for a dedicated rabbitmq cluster for notifications. Add new messagingBus and notificationsBus interfaces to hold cluster, user and vhost names for optional usage. The controller adds these values to the TransportURL create request when present. Additionally, we migrate RabbitMQ cluster name to RabbitMq config struct using DefaultRabbitMqConfig from infra-operator to automatically populate the new Cluster field from legacy RabbitMqClusterName. Example usage: spec: messagingBus: cluster: rpc-rabbitmq user: rpc-user vhost: rpc-vhost notificationsBus: cluster: notifications-rabbitmq user: notifications-user vhost: notifications-vhost Jira: https://issues.redhat.com/browse/OSPRH-23819

softwarefactory-project-zuul · 2026-02-05T15:35:58Z

Merge Failed.

This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset.
Warning:
Error merging github.com/openstack-k8s-operators/openstack-operator for 1779,d0bba951fd942312b6e33713b2c686fed2fe5bf6

lmiccini · 2026-02-05T15:38:08Z

recheck

softwarefactory-project-zuul · 2026-02-05T15:46:28Z

This change depends on a change that failed to merge.

Change openstack-k8s-operators/openstack-operator#1797 is needed.

lmiccini · 2026-02-05T15:46:42Z

recheck

lmiccini · 2026-02-05T17:00:05Z

/retest

lmiccini · 2026-02-05T18:12:31Z

/test ironic-operator-build-deploy-kuttl

softwarefactory-project-zuul · 2026-02-07T06:04:41Z

This change depends on a change that failed to merge.

Change openstack-k8s-operators/openstack-operator#1797 is needed.

lmiccini · 2026-02-07T06:04:57Z

recheck

openshift-ci · 2026-02-07T08:10:04Z

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: lmiccini

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

stuggi · 2026-02-07T08:10:05Z

/override ci/prow/precommit-check

openshift-ci · 2026-02-07T08:10:10Z

@stuggi: Overrode contexts on behalf of stuggi: ci/prow/precommit-check

Details

In response to this:

/override ci/prow/precommit-check

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

openshift-ci bot requested review from stuggi and viroel December 18, 2025 12:41

lmiccini added the do-not-merge/hold label Dec 18, 2025

lmiccini force-pushed the rabbitmq_vhosts branch from e50135d to be135db Compare December 18, 2025 12:42

lmiccini changed the title ~~Add support for a dedicated rabbitmq cluster for notifications.~~ Rabbitmq vhost and user support Dec 18, 2025

lmiccini force-pushed the rabbitmq_vhosts branch 3 times, most recently from ad702cf to 60495bd Compare December 19, 2025 13:45

openshift-merge-robot added the needs-rebase label Jan 9, 2026

lmiccini force-pushed the rabbitmq_vhosts branch from 60495bd to e758a1e Compare January 19, 2026 10:40

lmiccini force-pushed the rabbitmq_vhosts branch from e758a1e to 4fa3f92 Compare January 19, 2026 11:24

openshift-merge-robot removed the needs-rebase label Jan 19, 2026

lmiccini force-pushed the rabbitmq_vhosts branch 7 times, most recently from 2733681 to a64b80e Compare January 22, 2026 09:19

lmiccini force-pushed the rabbitmq_vhosts branch from a64b80e to 5a447c5 Compare January 26, 2026 08:42

lmiccini removed the do-not-merge/hold label Jan 26, 2026

openshift-merge-robot added the needs-rebase label Jan 26, 2026

lmiccini force-pushed the rabbitmq_vhosts branch from 5a447c5 to 74553cf Compare January 26, 2026 10:53

openshift-merge-robot removed the needs-rebase label Jan 26, 2026

lmiccini force-pushed the rabbitmq_vhosts branch from 74553cf to 1f3ba45 Compare January 26, 2026 12:24

juliakreger reviewed Feb 2, 2026

View reviewed changes

steveb reviewed Feb 2, 2026

View reviewed changes

steveb reviewed Feb 3, 2026

View reviewed changes

steveb requested changes Feb 3, 2026

View reviewed changes

openshift-ci bot assigned steveb Feb 3, 2026

lmiccini force-pushed the rabbitmq_vhosts branch from 7901596 to 88bdbd5 Compare February 3, 2026 06:33

hjensas reviewed Feb 5, 2026

View reviewed changes

internal/controller/ironic_controller.go Show resolved Hide resolved

internal/controller/ironic_controller.go Show resolved Hide resolved

lmiccini added 2 commits February 5, 2026 16:27

Make deprecated parameter optional

ded6fea

lmiccini force-pushed the rabbitmq_vhosts branch from 88bdbd5 to 0116b23 Compare February 5, 2026 15:35

Extract and reuse transporturl functions

c68484b

lmiccini force-pushed the rabbitmq_vhosts branch from 0116b23 to c68484b Compare February 7, 2026 05:56

stuggi added lgtm approved labels Feb 7, 2026

openshift-merge-bot bot merged commit 6dce1a5 into openstack-k8s-operators:main Feb 7, 2026
7 checks passed

Conversation

lmiccini commented Dec 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Checklist before requesting a review

Uh oh!

softwarefactory-project-zuul bot commented Jan 19, 2026

Uh oh!

softwarefactory-project-zuul bot commented Jan 22, 2026

Uh oh!

softwarefactory-project-zuul bot commented Jan 26, 2026

Uh oh!

softwarefactory-project-zuul bot commented Jan 26, 2026

Uh oh!

lmiccini commented Jan 26, 2026

Uh oh!

juliakreger Feb 2, 2026

Choose a reason for hiding this comment

Uh oh!

steveb Feb 2, 2026

Choose a reason for hiding this comment

Uh oh!

lmiccini Feb 3, 2026

Choose a reason for hiding this comment

Uh oh!

steveb Feb 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

steveb Feb 3, 2026

Choose a reason for hiding this comment

Uh oh!

lmiccini Feb 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

steveb commented Feb 3, 2026

Uh oh!

steveb left a comment

Choose a reason for hiding this comment

Uh oh!

softwarefactory-project-zuul bot commented Feb 3, 2026

Uh oh!

lmiccini commented Feb 3, 2026

Uh oh!

lmiccini commented Feb 3, 2026

Uh oh!

Uh oh!

Uh oh!

softwarefactory-project-zuul bot commented Feb 5, 2026

Uh oh!

lmiccini commented Feb 5, 2026

Uh oh!

softwarefactory-project-zuul bot commented Feb 5, 2026

Uh oh!

lmiccini commented Feb 5, 2026

Uh oh!

lmiccini commented Feb 5, 2026

Uh oh!

lmiccini commented Feb 5, 2026

Uh oh!

softwarefactory-project-zuul bot commented Feb 7, 2026

Uh oh!

lmiccini commented Feb 7, 2026

Uh oh!

openshift-ci bot commented Feb 7, 2026

Uh oh!

stuggi commented Feb 7, 2026

Uh oh!

openshift-ci bot commented Feb 7, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

lmiccini commented Dec 18, 2025 •

edited

Loading

steveb Feb 3, 2026 •

edited

Loading

lmiccini Feb 3, 2026 •

edited

Loading