Skip to content

Refactor auth config to eliminate duplication#674

Merged
openshift-merge-bot[bot] merged 1 commit intoopenstack-k8s-operators:mainfrom
hjensas:config-cleanup
Mar 4, 2026
Merged

Refactor auth config to eliminate duplication#674
openshift-merge-bot[bot] merged 1 commit intoopenstack-k8s-operators:mainfrom
hjensas:config-cleanup

Conversation

@hjensas
Copy link
Contributor

@hjensas hjensas commented Feb 2, 2026

Move auth_url into auth_config template definitions and consolidate auth config across templates.

Changes:

  • Add auth_url to auth_config template in common/ironic.conf, inspector, and neutron-agent configs
  • Remove duplicate auth_url lines across all templates
  • Add [ironic] section to common config for API client authentication
  • Remove duplicate auth sections from ironicapi/01-api.conf
  • Update ironicapi test to check ironic.conf for auth configuration

Assisted-By: Claude Code/claude-4.5-sonnet

Checklist before requesting a review

  • I have performed a self-review of my code and confirmed it passes tests
  • Performed pre-commit run --all
  • Tested operator image in a test/dev environment. It can be CRC via install_yamls or a hotstack instance (optional)
  • Verified that no failures present in logs(optional):
    • ironic-operator-build-deploy-kuttl
    • podified-multinode-ironic-deployment

@openshift-ci openshift-ci bot requested review from steveb and stuggi February 2, 2026 17:26
@openshift-ci openshift-ci bot added the approved label Feb 2, 2026
@hjensas hjensas removed the approved label Feb 2, 2026
Move auth_url into auth_config template definitions and consolidate
auth config across templates.

Changes:
- Add auth_url to auth_config template in common/ironic.conf,
  inspector, and neutron-agent configs
- Remove duplicate auth_url lines across all templates
- Add [ironic] section to common config for API client authentication
- Remove duplicate auth sections from ironicapi/01-api.conf
- Update ironicapi test to check ironic.conf for auth configuration

Assisted-By: Claude Code/claude-4.5-sonnet
Signed-off-by: Harald Jensås <[email protected]>
@softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/ca2039b0aa174f0984870e8e16081fc5

openstack-k8s-operators-content-provider FAILURE in 13m 23s
⚠️ podified-multinode-ironic-deployment SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider

Copy link
Collaborator

@steveb steveb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Job failure was due to not being able to pull docker://registry.access.redhat.com/ubi9/ubi-minimal:9.6 so not related

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 3, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hjensas, steveb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@hjensas
Copy link
Contributor Author

hjensas commented Mar 4, 2026

recheck

@openshift-merge-bot openshift-merge-bot bot merged commit bba16b0 into openstack-k8s-operators:main Mar 4, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants