Move to VerifySecretFields to reject invalid passwords#683
Merged
openshift-merge-bot[bot] merged 1 commit intoopenstack-k8s-operators:mainfrom Mar 10, 2026
Merged
Conversation
Service passwords are usually defined in the osp-secret and propagated to their config. This patch moves from verifyServiceSecret to the new lib-common VerifySecretFields that is able to call a validator to accept or reject the password field and set the appropriate errorMsg to the InputReady Condition. This patch also reworks the associated conditions to be consistent with the other operators. Signed-off-by: Francesco Pantano <fpantano@redhat.com>
hjensas
approved these changes
Mar 10, 2026
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fmount, hjensas The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit 9f43f52
into
openstack-k8s-operators:main
7 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Servicepasswords are usually defined in theosp-secretand propagated to their config. This patch moves fromverifyServiceSecret(orGetSecret) to the new lib-commonVerifySecretFieldsthat is able to call a validator to accept or reject the password field and set the appropriateerrorMsgto theInputReadyCondition.This patch also reworks the associated conditions to be consistent with the other operators.
Jira: https://issues.redhat.com/browse/OSPRH-26429