Remove unused legacy code and tests #1670
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit removes unused legacy code that is no longer referenced anywhere in the codebase: Removed Handlers (3 files): - app/handlers/signup_start.rb - app/handlers/signup_verify_email.rb - app/handlers/signup_verify_by_token.rb These handlers were part of the legacy signup flow that has been completely replaced by the newflow signup handlers. No code references these handlers anymore. Removed Routines (2 files): - app/routines/destroy_when_association_empty.rb - app/routines/update_user_lead_info.rb DestroyWhenAssociationEmpty was a utility routine with no callers. UpdateUserLeadInfo was incomplete and never actually called despite a comment referencing it. Removed Migration (1 file): - db/migrate/20191204193412_drop_openstax_salesforce_users.openstax_salesforce.rb This 2019 migration had a TODO comment indicating it should be removed after all servers have been migrated. The migration has been executed and the table is already dropped. Updated Files (1 file): - lib/tasks/accounts/create_leads_for_instructors_not_sent_to_sf.rake Removed outdated comment referencing the now-deleted UpdateUserLeadInfo routine. All removed code was verified to have zero references in the codebase. No test files were found for any of the removed code, confirming they were truly unused.
Copilot finished reviewing on behalf of
mwvolo
November 12, 2025 02:37
There was a problem hiding this comment.
Pull Request Overview
This PR removes unused legacy code related to the old signup flow, along with an obsolete migration and a routine that was never actually called. The changes clean up the codebase by eliminating dead code.
- Removed 3 legacy signup handlers that were replaced by newflow implementations
- Removed 2 unused routines with no active callers
- Removed an executed migration from 2019 that had been marked for deletion
- Updated a rake task to remove an outdated comment referencing deleted code
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| lib/tasks/accounts/create_leads_for_instructors_not_sent_to_sf.rake | Removed obsolete comment referencing the deleted UpdateUserLeadInfo routine |
| db/migrate/20191204193412_drop_openstax_salesforce_users.openstax_salesforce.rb | Deleted executed migration that was marked with TODO for removal after all servers migrated |
| app/routines/update_user_lead_info.rb | Removed unused routine for updating user lead information from Salesforce |
| app/routines/destroy_when_association_empty.rb | Removed utility routine with no callers in the codebase |
| app/handlers/signup_verify_email.rb | Removed legacy signup handler for email verification |
| app/handlers/signup_verify_by_token.rb | Removed legacy signup handler for token-based verification |
| app/handlers/signup_start.rb | Removed legacy signup handler for initiating signup flow |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit removes unused legacy code that is no longer referenced anywhere in the codebase:
Removed Handlers (3 files):
These handlers were part of the legacy signup flow that has been completely replaced by the newflow signup handlers. No code references these handlers anymore.
Removed Routines (2 files):
DestroyWhenAssociationEmpty was a utility routine with no callers. UpdateUserLeadInfo was incomplete and never actually called despite a comment referencing it.
Removed Migration (1 file):
This 2019 migration had a TODO comment indicating it should be removed after all servers have been migrated. The migration has been executed and the table is already dropped.
Updated Files (1 file):