Fix: Replace invalid UncheckedIOException usage in BinaryParser #90
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Please don't mix unrelated changes in a single PR. In this case the code changes with unrelated whitespace or wording changes. This makes is very hard to review the change set. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a compile-time error in BinaryParser.java caused by improper wrapping of a non-IOException inside UncheckedIOException.
Details
Removed: throw new UncheckedIOException(new FileFormatException(e));
Added: throw new FileFormatException(e);
FileFormatException already extends RuntimeException, making it suitable to throw directly.
Also added a small safety check in getStringById() to prevent potential ArrayIndexOutOfBoundsException for malformed PBF data.
Impact
Fixes compilation errors in the Java build (mvn package or ant).
Improves runtime safety and error clarity when parsing malformed OSM PBF files.