Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Linux and Windows CI builds using GitHub Actions #601

Merged
merged 23 commits into from
May 20, 2020
Merged

Added Linux and Windows CI builds using GitHub Actions #601

merged 23 commits into from
May 20, 2020

Conversation

RICCIARDI-Adrien
Copy link
Contributor

Windows build should also be easier even for developing purposes.

@TeslaRus
Copy link
Contributor

TeslaRus commented May 18, 2020

try this AL internal, please https://github.com/TeslaRus/OpenTomb/tree/master/extern/al
it works on Linux and MinGW too

@RICCIARDI-Adrien
Copy link
Contributor Author

OK.
What C files did you compile ? All the ones contained in al subdirectories ?
May I add a CMakeFiles.txt to al directory ?

@TeslaRus
Copy link
Contributor

yes, all files
May I add a CMakeFiles.txt to al directory ? - ok )

@RICCIARDI-Adrien
Copy link
Contributor Author

@TeslaRus, are you using MinGW on Cygwin ?
It seems that Windows threads have been removed from your OpenAL version, only pthreads are left.

@TeslaRus
Copy link
Contributor

yes, mingw has pthreads library (cut version, but enough for AL)

@RICCIARDI-Adrien
Copy link
Contributor Author

New OpenAL is now fully integrated. It is statically linked to avoid deploying one more DLL.

@TeslaRus TeslaRus merged commit 463363c into opentomb:master May 20, 2020
@vvs-
Copy link
Contributor

vvs- commented May 20, 2020

I've just checked the result: OpenTomb repository size has doubled because of the Windows binaries. I think that was not a good idea, because git is really bad at handling binaries. I'd split those away or this blow up could become a problem with time.

@vvs-
Copy link
Contributor

vvs- commented May 22, 2020

Reverted as per discussion in #600.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants