UCT/CUDA/CUDA_COPY: Enabled memory attributes query after switching CUDA GPU. #10388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rakhmets
force-pushed
the
topic/gtest-switch-gpu
branch
from
d31bb61 to
1adcb5e
Compare
tvegas1
reviewed
Dec 18, 2024
test/gtest/ucp/test_ucp_mmap.cc
Outdated
| class test_ucp_mmap_mgpu : public ucs::test { | ||
| }; | ||
|
|
||
| UCS_TEST_F(test_ucp_mmap_mgpu, switch_gpu) { |
There was a problem hiding this comment.
do we need to add tests for transfer cuda_copy or cuda_ipc, mem type cuda or vmm/mallocasync:
- buf1 on device1, buf2 on device2, copy happening under progress with context of unrelated device3
There was a problem hiding this comment.
Agree, we will need more test cases.
The test in this PR is the simplest one. And it fails. Once it is fixed, we will add more scenarios.
|
/azp run UCX PR |
|
Azure Pipelines successfully started running 1 pipeline(s). |
rakhmets
force-pushed
the
topic/gtest-switch-gpu
branch
from
4adf57b to
6d38f73
Compare
rakhmets
changed the title
brminich
reviewed
Feb 12, 2025
brminich
previously approved these changes
Feb 12, 2025
rakhmets
changed the title
brminich
reviewed
Feb 13, 2025
brminich
approved these changes
Feb 13, 2025
tvegas1
approved these changes
Feb 13, 2025
iyastreb
approved these changes
Feb 14, 2025
| ASSERT_EQ(cudaGetDevice(&device), cudaSuccess); | ||
| ASSERT_EQ(cudaSetDevice((device + 1) % num_devices), cudaSuccess); | ||
|
|
||
| const int size = 16; |
There was a problem hiding this comment.
cosmetic: size_t looks more appropriate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Enabled memory attributes query by
cuda_cpymemory domain after switching CUDA GPU.Added test.
Without the changes in
cuda_cpymemory domain the test fails with the following error: