UCT/IB/EFA/SRD: Initial add of endpoint #10447
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brminich
reviewed
Jan 24, 2025
brminich
previously approved these changes
Jan 27, 2025
yosefe
reviewed
Feb 3, 2025
src/uct/ib/efa/srd/srd_iface.h
Outdated
| void uct_srd_iface_remove_ep(uct_srd_iface_t *iface, uct_srd_ep_t *ep); | ||
|
|
||
| ucs_status_t uct_srd_iface_unpack_peer_address(uct_srd_iface_t *iface, | ||
| const uct_ib_address_t *ib_addr, |
Comment on lines
+628
to
+634
| /** | ||
| * Instantiate the parametrized test case for the SRD transports | ||
| * | ||
| * @param _test_case Test case class, derived from uct_test. | ||
| */ | ||
| #define UCT_INSTANTIATE_SRD_TEST_CASE(_test_case) \ | ||
| _UCT_INSTANTIATE_TEST_CASE(_test_case, srd) |
There was a problem hiding this comment.
do we really need such macro if we plan to add it to UCT_INSTANTIATE_TEST_CASE ?
There was a problem hiding this comment.
i think we most likely will end-up having to add srd specific tests cases (as there are ud and rc TC)
brminich
reviewed
Feb 4, 2025
src/uct/ib/efa/srd/srd_ep.c
Outdated
Comment on lines
71
to
91
| if (ucs_test_all_flags(params->field_mask, | ||
| UCT_EP_PARAM_FIELD_DEV_ADDR | | ||
| UCT_EP_PARAM_FIELD_IFACE_ADDR)) { | ||
|
|
||
| self->conn_sn = ucs_atomic_fadd64(&uct_srd_ep_conn_sn, 1); | ||
|
|
||
| /* Connect it to the interface */ | ||
| status = uct_srd_ep_connect_to_iface(self, ib_addr, if_addr); | ||
| if (status != UCS_OK) { | ||
| goto err_ep_destroy; | ||
| } | ||
|
|
||
| /* Generate peer address */ | ||
| status = uct_srd_iface_unpack_peer_address(iface, ib_addr, if_addr, | ||
| self->path_index, | ||
| &self->peer_address); | ||
| if (status != UCS_OK) { | ||
| goto err_ep_destroy; | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
minor:
Suggested change
| if (ucs_test_all_flags(params->field_mask, | |
| UCT_EP_PARAM_FIELD_DEV_ADDR | | |
| UCT_EP_PARAM_FIELD_IFACE_ADDR)) { | |
| self->conn_sn = ucs_atomic_fadd64(&uct_srd_ep_conn_sn, 1); | |
| /* Connect it to the interface */ | |
| status = uct_srd_ep_connect_to_iface(self, ib_addr, if_addr); | |
| if (status != UCS_OK) { | |
| goto err_ep_destroy; | |
| } | |
| /* Generate peer address */ | |
| status = uct_srd_iface_unpack_peer_address(iface, ib_addr, if_addr, | |
| self->path_index, | |
| &self->peer_address); | |
| if (status != UCS_OK) { | |
| goto err_ep_destroy; | |
| } | |
| } | |
| if (!ucs_test_all_flags(params->field_mask, | |
| UCT_EP_PARAM_FIELD_DEV_ADDR | | |
| UCT_EP_PARAM_FIELD_IFACE_ADDR)) { | |
| return UCS_OK; | |
| } | |
| self->conn_sn = ucs_atomic_fadd64(&uct_srd_ep_conn_sn, 1); | |
| /* Connect it to the interface */ | |
| status = uct_srd_ep_connect_to_iface(self, ib_addr, if_addr); | |
| if (status != UCS_OK) { | |
| goto err_ep_destroy; | |
| } | |
| /* Generate peer address */ | |
| status = uct_srd_iface_unpack_peer_address(iface, ib_addr, if_addr, | |
| self->path_index, | |
| &self->peer_address); | |
| if (status != UCS_OK) { | |
| goto err_ep_destroy; | |
| } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Add initial SRD endpoint creation.