UCP/PROTO: Handle request status correctly and refactor #10473
+77
−65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iyastreb
reviewed
Feb 4, 2025
| @@ -134,8 +134,8 @@ static UCS_F_ALWAYS_INLINE ucs_status_t ucp_am_eager_multi_bcopy_send_func( | |||
| packed_size = uct_ep_am_bcopy(uct_ep, UCP_AM_ID_AM_FIRST, | |||
| ucp_am_eager_multi_bcopy_pack_args_first, | |||
| &pack_ctx, 0); | |||
| status = ucp_proto_bcopy_send_func_status(packed_size); | |||
| status = ucp_proto_am_handle_user_header_send_status(req, status); | |||
| status = ucp_am_handle_user_header_send_status_common( | |||
There was a problem hiding this comment.
Is it possible to reproduce the original failure with unit test?
If so it would be helpful to add it
There was a problem hiding this comment.
I think it's a good idea but not for this PR because for now it's not practical.
To do this we need to add some hint to UCX mpool object that will cause allocation to fail, I don't think this is something this PR suppose to do but we can consider it for the future to test this case and other use cases that involve memory allocation.
Comment on lines
+137
to
+139
| ucp_am_handle_user_header_send_status_common(ucp_request_t *req, | ||
| ucs_status_t status, int abort, | ||
| int release) |
There was a problem hiding this comment.
#10452 (comment) reference to initial conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Why?
In some flows of send operations we can reach
ucs_fatalbecause status is not handled properly.How?
Instead of returning unexpected status code we should abort operation and return
UCS_OK