Add Dockerfile to replace scripts #29 #35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
update.sh will update and install essential tools, also install java. other two scripts weren't working on my end that's why I commented them
didn't want to install brew on docker image, so this is easier method.
removed brew because it isn't installed in docker image
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add basic Dockerfile that replaces main scripts work.
Include Dockerfile in .gitpod.yml file and remove tasks that runs the old scripts.
Add update.sh file which install necessary tools and also install java.
I've tested that these tools are installed in the container and running fine:
Note: I'm not sure if this is the result you expect so please try and tell me what to improve.