🐞 Replace the mandatory PatchCore center crop with an optional one, add the same to CFA #2623
+102
−16
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
This PR replaces the mandatory PatchCore center crop with an optional one. It solves that center crop transform is often not needed in practical applications, but at the same time, it allows easily add it to reproduce paper settings:
The same option is provided for CFA, which, like PatchCore, uses the center crop in its official implementation.
Not having a center crop transform does not affect how these models work. It just improves results on data where the object is in the center of the image, and some background can be removed safely without missing defects, which is not necessarily the case in practical applications.
✨ Changes
If no
center_crop_size
is provided, the center crop transform won't be applied to the PatchCore and CFA models. If it is provided and smaller than the image size, it will be applied as before.Select what type of change your PR is:
✅ Checklist
Before you submit your pull request, please make sure you have completed the following steps:
For more information about code review checklists, see the Code Review Checklist.