do not force http protocol versions for api #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is no requirement to use http2 in kubernetes api. Since we use transport=>tls, by default gun will try http2 and fallback to http.
|
I'm not convinced that that works. The watch API needs a persistent connection, that is either HTTP2 or WebSockets. Plain HTTP might cause lots of reconnects of the watch connection. That would probably lead to problems. Also, I don't see a need to support another dialect of kubernetes. The plan is to drop VXLAN controller as soon as possible. This fixed version is only a stop-gap measure and needs to die. |
|
BTW: can you point to a authoritative source that documented that HTTP2 for the API server is unsupported for the API server? I tried to find reference, but couldn't locate one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is no requirement to use http2 in kubernetes api.
Since we use transport=>tls, by default gun will try http2 and fallback to http.