Skip to content

Conversation

@swcurran
Copy link
Contributor

Signed-off-by: Stephen Curran swcurran@gmail.com

Signed-off-by: Stephen Curran <swcurran@gmail.com>
@swcurran swcurran requested review from a team January 20, 2026 22:28
Signed-off-by: Stephen Curran <swcurran@gmail.com>
Signed-off-by: Stephen Curran <swcurran@gmail.com>
esune
esune previously approved these changes Jan 21, 2026
Copy link
Member

@esune esune left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏻

@swcurran
Copy link
Contributor Author

Any comments on what is failing on the tests? Presumably not something in this PR?

@PatStLouis
Copy link
Contributor

both tests are failing at revocation. I re-ran the integration tests and the failure is consistent. I'll try to investigate.

@PatStLouis
Copy link
Contributor

Here's some findings for the interop tests:

It's failing here:
https://github.com/OpSecId/owl-agent-test-harness/blob/654b1b60a82fe8d7cc65100901a58e649d354203/aries-test-harness/features/steps/0454-present-proof-v2-v3.py#L366

its expecting a 200 but is getting a 500 from the backchannel.

This is the following feature:
https://github.com/OpSecId/owl-agent-test-harness/blob/654b1b60a82fe8d7cc65100901a58e649d354203/aries-test-harness/features/0454-present-proof-v2.feature#L82

With tags: @ProofType_Ed25519Signature2018 @DidMethod_key

Looking at the backchannel trace log:

2026-01-21 18:28:31,500 acapy_agent.admin.server INFO Bad request during POST /present-proof-2.0/records/3d4d050e-4f38-41dc-920d-be36e8098d9a/verify-presentation: Presentation exchange 3d4d050e-4f38-41dc-920d-be36e8098d9a in request-sent state (must be presentation-received)
2026-01-21 18:28:31,500 aiohttp.access INFO 174.96.0.1 [21/Jan/2026:18:28:31 +0000] "POST /present-proof-2.0/records/3d4d050e-4f38-41dc-920d-be36e8098d9a/verify-presentation HTTP/1.1" 400 345 "-" "Python/3.13 aiohttp/3.13.3"
Exception: Extra data: line 1 column 4 (char 3)
Traceback (most recent call last):
  File "/aries-backchannels/python/agent_backchannel.py", line 287, in _post_command_backchannel
    (resp_status, resp_text) = await self.make_agent_POST_request(command)
                               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/aries-backchannels/acapy/acapy_backchannel.py", line 955, in make_agent_POST_request
    (resp_status, resp_text) = await self.handle_proof_v2_POST(command)
                               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/aries-backchannels/acapy/acapy_backchannel.py", line 1471, in handle_proof_v2_POST
    resp_text = self.move_field_to_top_level(resp_text, "state")
  File "/aries-backchannels/acapy/acapy_backchannel.py", line 1478, in move_field_to_top_level
    resp_json = json.loads(resp_text)
  File "/usr/local/lib/python3.13/json/__init__.py", line 346, in loads
    return _default_decoder.decode(s)
           ~~~~~~~~~~~~~~~~~~~~~~~^^^
  File "/usr/local/lib/python3.13/json/decoder.py", line 348, in decode
    raise JSONDecodeError("Extra data", s, end)
json.decoder.JSONDecodeError: Extra data: line 1 column 4 (char 3)

It seems the presentation exchange state is stuck in presentation-sent when it should be presentation received.

I believe the culprit is the citizenship context taking some time to load (19s):
https://w3id.org/citizenship

Caching this context might fix this issue:
https://github.com/openwallet-foundation/acapy/tree/main/acapy_agent/vc/ld_proofs/resources

@swcurran swcurran marked this pull request as draft January 21, 2026 21:17
Signed-off-by: Stephen Curran <swcurran@gmail.com>
@swcurran swcurran marked this pull request as ready for review January 21, 2026 21:20
@swcurran
Copy link
Contributor Author

Still erroring off -- looks like in the same place. Another look @PatStLouis ?

@PatStLouis
Copy link
Contributor

@swcurran I fixed one of the failing tests, the BDD Interop which is now passing. The second error has to do with rotating the revocation registry, I will investigate one.

@PatStLouis
Copy link
Contributor

@swcurran this PR fixed the issue locally #4028

See PR for details, merging this should have the registry rotation test pass.

@swcurran swcurran marked this pull request as draft January 22, 2026 17:49
@swcurran swcurran marked this pull request as ready for review January 22, 2026 17:54
@sonarqubecloud
Copy link

@swcurran swcurran merged commit 2eab575 into openwallet-foundation:main Jan 23, 2026
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants