-
Notifications
You must be signed in to change notification settings - Fork 532
1.5.0rc1 #4026
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1.5.0rc1 #4026
Conversation
Signed-off-by: Stephen Curran <swcurran@gmail.com>
Signed-off-by: Stephen Curran <swcurran@gmail.com>
esune
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍🏻
|
Any comments on what is failing on the tests? Presumably not something in this PR? |
|
both tests are failing at revocation. I re-ran the integration tests and the failure is consistent. I'll try to investigate. |
|
Here's some findings for the interop tests: It's failing here: its expecting a 200 but is getting a 500 from the backchannel. This is the following feature: With tags: @ProofType_Ed25519Signature2018 @DidMethod_key Looking at the backchannel trace log: It seems the presentation exchange state is stuck in presentation-sent when it should be presentation received. I believe the culprit is the citizenship context taking some time to load (19s): Caching this context might fix this issue: |
Signed-off-by: Stephen Curran <swcurran@gmail.com>
|
Still erroring off -- looks like in the same place. Another look @PatStLouis ? |
|
@swcurran I fixed one of the failing tests, the BDD Interop which is now passing. The second error has to do with rotating the revocation registry, I will investigate one. |
Signed-off-by: Stephen Curran <swcurran@gmail.com>
|



Signed-off-by: Stephen Curran swcurran@gmail.com