Skip to content
This repository was archived by the owner on Oct 5, 2018. It is now read-only.

Adapt to newer version of tomcat 8.5: The StandardRoot needs a sort as well #2

Merged
merged 1 commit into from
Feb 26, 2018

Conversation

pludov
Copy link

@pludov pludov commented Feb 22, 2018

The current version was not working for 8.5.28 tomcat.
Tomcat is now relying on the order from DirResourceSet.list. The patch add a StandardRoot that override the standard one for sorting content of WEB-INF/lib

@gsmet
Copy link
Contributor

gsmet commented Feb 22, 2018

@pludov looks good to me. Unfortunately, I left the org hosting the project and I cannot merge anything as I don't have the ad hoc permissions.

@olivierdepriester could you merge the PR please? This project is referenced in the (very popular) Tomcat issue opened to restore the sort order and is used by a few people out there. And if you don't mind giving me back the permissions on this particular project, that would be nice.

Thanks!

@mdpollard
Copy link

Wow, just encountered this issue today, and the fix was ready! Minor comment, the context element should be "Resources" with an "s":
<Resources className="fr.openwide.tomcat.catalina.loader.OrderedStandardRoot" />

@gsmet
Copy link
Contributor

gsmet commented Feb 22, 2018

@pludov can you fix the issue and force-push? Thanks!

@mdpollard thanks for spotting the issue.

@pludov
Copy link
Author

pludov commented Feb 23, 2018

@gsmet: done !

@olivierdepriester olivierdepriester merged commit 0b49786 into openwide-java:master Feb 26, 2018
@olivierdepriester
Copy link
Member

@gsmet @pludov @mdpollard merged on master

@gsmet
Copy link
Contributor

gsmet commented Feb 26, 2018

@olivierdepriester thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants