luci-mod-status: add dynamic ethernet devices to port status view#8525
luci-mod-status: add dynamic ethernet devices to port status view#8525KarstenH792 wants to merge 1 commit intoopenwrt:masterfrom
Conversation
|
Just as a heads up, the workflow test might fail the commit due to the Contributing Guidelines.
Thought you might like to know in advance as these workflow tests can take some time for them to run. |
This comment has been minimized.
This comment has been minimized.
e334022 to
1fcf0a1
Compare
|
Thanks for the heads up — fixed commit format, author details and line wrapping.
…> From: Owl ***@***.***>
> Date: 5 April 2026 at 17:57:20 AEST
> To: openwrt/luci ***@***.***>
> Cc: KarstenH792 ***@***.***>, Author ***@***.***>
> Subject: Re: [openwrt/luci] luci-mod-status: add dynamic ethernet devices to port status view (PR #8525)
> Reply-To: openwrt/luci ***@***.***>
>
> owlsy left a comment [(openwrt/luci#8525)](#8525 (comment))
>
> Just as a heads up, the workflow test might fail the commit due to the [Contributing Guidelines](https://github.com/openwrt/luci/blob/master/CONTRIBUTING.md).
>
> -
>
> Commit subject I believe needs to be less than 50 characters per line, and have the subject prefixed with the component name (just like you did for the pull request title). Something like: luci-mod-status: dynamic ethernet to port view.
>
> -
>
> Commit message must be broken up into multiple lines, and I believe less than 70 characters per line is the requirement. Pressing return to continue the sentence to a new line is what I've done to accomplish this.
>
> -
>
> For the commit Author and Signed-off-by, you cannot use a GitHub noreply email. If you are not comfortable using your personal email address, you could create an alternative email address for situations like this. Then, change your email address for these checks to pass.
>
> Thought you might like to know in advance as these workflow tests can take some time for them to run.
>
> —
> Reply to this email directly, [view it on GitHub](#8525 (comment)), or [unsubscribe](https://github.com/notifications/unsubscribe-auth/AZLE4AXZAA3IQG3NK7LLKET4UH7U5AVCNFSM6AAAAACXNCUDQSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHM2DCOBYGQ4TAMBVGI).
> You are receiving this because you authored the thread.Message ID: ***@***.***>
|
This comment has been minimized.
This comment has been minimized.
Extend port status view to include dynamically detected ethernet interfaces (e.g. USB adapters). Devices are merged into the existing port list if not already present. Loopback interfaces are excluded. Filter against /sys/class/net to avoid stale entries after device removal. Tested on: - GL.iNet GL-MT6000 - OpenWrt 25.12.1 - Apple USB ethernet adapters (100 Mbps and 2.5 Gbps) Verified link state changes and hotplug (add/remove). Signed-off-by: Karsten Hoehn <[email protected]>
1fcf0a1 to
67984da
Compare
Extend the port status view to include dynamically detected ethernet interfaces (e.g. USB adapters) in addition to board-defined ports.
Devices are derived from netifd's device map and merged into the existing port list if not already present. Loopback interfaces are excluded.
To ensure correct hotplug behaviour, the device list is filtered against the current kernel device list (/sys/class/net), preventing stale entries from being displayed after device removal.
Tested on:
Verified link state changes and device hotplug (add/remove).