inotify-tools: fix compilation with musl 1.2.4 - #21044
Merged
Merged
Conversation
30 tasks
Member
|
Ping @dangowrt can you review these fixes? |
Fixes errors in the form of:
inotifytools.c: In function 'inotifytools_watch_recursively_with_exclude':
inotifytools.c:1335:30: error: storage size of 'my_stat' isn't known
1335 | static struct stat64 my_stat;
| ^~~~~~~
inotifytools.c:1342:36: error: implicit declaration of function 'lstat64'; did you mean 'lstat'? [-Werror=implicit-function-declaration]
1342 | if ( -1 == lstat64( next_file, &my_stat ) ) {
| ^~~~~~~
| lstat
inotifytools.c:1335:30: error: unused variable 'my_stat' [-Werror=unused-variable]
1335 | static struct stat64 my_stat;
| ^~~~~~~
inotifytools.c: In function 'isdir':
inotifytools.c:1621:30: error: storage size of 'my_stat' isn't known
1621 | static struct stat64 my_stat;
| ^~~~~~~
inotifytools.c:1621:30: error: unused variable 'my_stat' [-Werror=unused-variable]
inotifytools.c:1630:1: error: control reaches end of non-void function [-Werror=return-type]
1630 | }
| ^
cc1: all warnings being treated as errors
Signed-off-by: Nick Hainke <vincent@systemli.org>
PolynomialDivision
force-pushed
the
inotify-tools-musl
branch
from
May 18, 2023 08:31
323db47 to
521a96e
Compare
Member
Author
|
I forgot to bump the PKG_RELEASE. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes errors in the form of:
inotifytools.c: In function 'inotifytools_watch_recursively_with_exclude': inotifytools.c:1335:30: error: storage size of 'my_stat' isn't known
1335 | static struct stat64 my_stat;
| ^~~~~~~
inotifytools.c:1342:36: error: implicit declaration of function 'lstat64'; did you mean 'lstat'? [-Werror=implicit-function-declaration]
1342 | if ( -1 == lstat64( next_file, &my_stat ) ) {
| ^~~~~~~
| lstat
inotifytools.c:1335:30: error: unused variable 'my_stat' [-Werror=unused-variable]
1335 | static struct stat64 my_stat;
| ^~~~~~~
inotifytools.c: In function 'isdir':
inotifytools.c:1621:30: error: storage size of 'my_stat' isn't known
1621 | static struct stat64 my_stat;
| ^~~~~~~
inotifytools.c:1621:30: error: unused variable 'my_stat' [-Werror=unused-variable]
inotifytools.c:1630:1: error: control reaches end of non-void function [-Werror=return-type]
1630 | }
| ^
cc1: all warnings being treated as errors
Maintainer: @dangowrt
Compile tested: CI
Run tested: no