ripgrep: fix compilation with musl 1.2.4 - #21058
Closed
PolynomialDivision wants to merge 1 commit into
Closed
Conversation
_LARGEFILE64_SOURCE has to be defined in the source, or CFLAGS can be used
to pass -D_LARGEFILE64_SOURCE to allow to keep using LFS64 definitions.
Fixes errors in the form of:
`std::sys::common::small_c_string::run_with_cstr_allocating':
std.8518be91-cgu.12:(.text.unlikely._ZN3std3sys6common14small_c_string24run_with_cstr_allocating17h6b06bca7baec94a5E+0x6c): undefined reference to `lstat64'
/builder/shared-workdir/build/sdk/staging_dir/toolchain-aarch64_cortex-a53_gcc-12.3.0_musl/bin/../lib/gcc/aarch64-openwrt-linux-musl/12.3.0/../../../../aarch64-openwrt-linux-musl/bin/ld: /builder/shared-workdir/build/sdk/staging_dir/hostpkg/cargo/lib/rustlib/aarch64-unknown-linux-musl/lib/libstd-36c8b3e4cde7f9f5.rlib(std-36c8b3e4cde7f9f5.std.8518be91-cgu.12.rcgu.o): in function `std::sys::common::small_c_string::run_with_cstr_allocating':
std.8518be91-cgu.12:(.text.unlikely._ZN3std3sys6common14small_c_string24run_with_cstr_allocating17haca87f88038fc6e4E+0x6c): undefined reference to `stat64'
/builder/shared-workdir/build/sdk/staging_dir/toolchain-aarch64_cortex-a53_gcc-12.3.0_musl/bin/../lib/gcc/aarch64-openwrt-linux-musl/12.3.0/../../../../aarch64-openwrt-linux-musl/bin/ld: /builder/shared-workdir/build/sdk/staging_dir/hostpkg/cargo/lib/rustlib/aarch64-unknown-linux-musl/lib/libstd-36c8b3e4cde7f9f5.rlib(std-36c8b3e4cde7f9f5.std.8518be91-cgu.6.rcgu.o): in function `std::backtrace_rs::symbolize::gimli::mmap':
std.8518be91-cgu.6:(.text._ZN3std12backtrace_rs9symbolize5gimli4mmap17h3ca3a47d6f44f0e2E+0x140): undefined reference to `fstat64'
/builder/shared-workdir/build/sdk/staging_dir/toolchain-aarch64_cortex-a53_gcc-12.3.0_musl/bin/../lib/gcc/aarch64-openwrt-linux-musl/12.3.0/../../../../aarch64-openwrt-linux-musl/bin/ld: /builder/shared-workdir/build/sdk/staging_dir/hostpkg/cargo/lib/rustlib/aarch64-unknown-linux-musl/lib/libstd-36c8b3e4cde7f9f5.rlib(std-36c8b3e4cde7f9f5.std.8518be91-cgu.8.rcgu.o): in function `std::fs::File::metadata':
std.8518be91-cgu.8:(.text._ZN3std2fs4File8metadata17hd8edcf64724e7edfE+0x28): undefined reference to `fstat64'
/builder/shared-workdir/build/sdk/staging_dir/toolchain-aarch64_cortex-a53_gcc-12.3.0_musl/bin/../lib/gcc/aarch64-openwrt-linux-musl/12.3.0/../../../../aarch64-openwrt-linux-musl/bin/ld: /builder/shared-workdir/build/sdk/staging_dir/hostpkg/cargo/lib/rustlib/aarch64-unknown-linux-musl/lib/libstd-36c8b3e4cde7f9f5.rlib(std-36c8b3e4cde7f9f5.std.8518be91-cgu.8.rcgu.o): in function `<std::fs::File as std::io::Read>::read_to_end':
std.8518be91-cgu.8:(.text._ZN47_$LT$std..fs..File$u20$as$u20$std..io..Read$GT$11read_to_end17ha59da013b024ed84E+0x3c): undefined reference to `fstat64'
/builder/shared-workdir/build/sdk/staging_dir/toolchain-aarch64_cortex-a53_gcc-12.3.0_musl/bin/../lib/gcc/aarch64-openwrt-linux-musl/12.3.0/../../../../aarch64-openwrt-linux-musl/bin/ld: std.8518be91-cgu.8:(.text._ZN47_$LT$std..fs..File$u20$as$u20$std..io..Read$GT$11read_to_end17ha59da013b024ed84E+0x58): undefined reference to `lseek64'
/builder/shared-workdir/build/sdk/staging_dir/toolchain-aarch64_cortex-a53_gcc-12.3.0_musl/bin/../lib/gcc/aarch64-openwrt-linux-musl/12.3.0/../../../../aarch64-openwrt-linux-musl/bin/ld: std.8518be91-cgu.8:(.text._ZN47_$LT$std..fs..File$u20$as$u20$std..io..Read$GT$11read_to_end17ha59da013b024ed84E+0xbc): undefined reference to `lseek64'
/builder/shared-workdir/build/sdk/staging_dir/toolchain-aarch64_cortex-a53_gcc-12.3.0_musl/bin/../lib/gcc/aarch64-openwrt-linux-musl/12.3.0/../../../../aarch64-openwrt-linux-musl/bin/ld: /builder/shared-workdir/build/sdk/staging_dir/hostpkg/cargo/lib/rustlib/aarch64-unknown-linux-musl/lib/libstd-36c8b3e4cde7f9f5.rlib(std-36c8b3e4cde7f9f5.std.8518be91-cgu.8.rcgu.o): in function `<std::fs::File as std::io::Read>::read_to_string':
std.8518be91-cgu.8:(.text._ZN47_$LT$std..fs..File$u20$as$u20$std..io..Read$GT$14read_to_string17hac1014cb573357e0E+0x3c): undefined reference to `fstat64'
/builder/shared-workdir/build/sdk/staging_dir/toolchain-aarch64_cortex-a53_gcc-12.3.0_musl/bin/../lib/gcc/aarch64-openwrt-linux-musl/12.3.0/../../../../aarch64-openwrt-linux-musl/bin/ld: std.8518be91-cgu.8:(.text._ZN47_$LT$std..fs..File$u20$as$u20$std..io..Read$GT$14read_to_string17hac1014cb573357e0E+0x58): undefined reference to `lseek64'
/builder/shared-workdir/build/sdk/staging_dir/toolchain-aarch64_cortex-a53_gcc-12.3.0_musl/bin/../lib/gcc/aarch64-openwrt-linux-musl/12.3.0/../../../../aarch64-openwrt-linux-musl/bin/ld: std.8518be91-cgu.8:(.text._ZN47_$LT$std..fs..File$u20$as$u20$std..io..Read$GT$14read_to_string17hac1014cb573357e0E+0xbc): undefined reference to `lseek64'
/builder/shared-workdir/build/sdk/staging_dir/toolchain-aarch64_cortex-a53_gcc-12.3.0_musl/bin/../lib/gcc/aarch64-openwrt-linux-musl/12.3.0/../../../../aarch64-openwrt-linux-musl/bin/ld: /builder/shared-workdir/build/sdk/staging_dir/hostpkg/cargo/lib/rustlib/aarch64-unknown-linux-musl/lib/libstd-36c8b3e4cde7f9f5.rlib(std-36c8b3e4cde7f9f5.std.8518be91-cgu.8.rcgu.o): in function `std::fs::metadata':
std.8518be91-cgu.8:(.text._ZN3std2fs8metadata17h025e05998b4f6791E+0x84): undefined reference to `stat64'
/builder/shared-workdir/build/sdk/staging_dir/toolchain-aarch64_cortex-a53_gcc-12.3.0_musl/bin/../lib/gcc/aarch64-openwrt-linux-musl/12.3.0/../../../../aarch64-openwrt-linux-musl/bin/ld: /builder/shared-workdir/build/sdk/staging_dir/hostpkg/cargo/lib/rustlib/aarch64-unknown-linux-musl/lib/libstd-36c8b3e4cde7f9f5.rlib(std-36c8b3e4cde7f9f5.std.8518be91-cgu.13.rcgu.o): in function `<std::sys::unix::fs::ReadDir as core::iter::traits::iterator::Iterator>::next':
std.8518be91-cgu.13:(.text._ZN86_$LT$std..sys..unix..fs..ReadDir$u20$as$u20$core..iter..traits..iterator..Iterator$GT$4next17h3aaa19c90400ffbbE+0x48): undefined reference to `readdir64'
/builder/shared-workdir/build/sdk/staging_dir/toolchain-aarch64_cortex-a53_gcc-12.3.0_musl/bin/../lib/gcc/aarch64-openwrt-linux-musl/12.3.0/../../../../aarch64-openwrt-linux-musl/bin/ld: std.8518be91-cgu.13:(.text._ZN86_$LT$std..sys..unix..fs..ReadDir$u20$as$u20$core..iter..traits..iterator..Iterator$GT$4next17h3aaa19c90400ffbbE+0x74): undefined reference to `readdir64'
/builder/shared-workdir/build/sdk/staging_dir/toolchain-aarch64_cortex-a53_gcc-12.3.0_musl/bin/../lib/gcc/aarch64-openwrt-linux-musl/12.3.0/../../../../aarch64-openwrt-linux-musl/bin/ld: /builder/shared-workdir/build/sdk/staging_dir/hostpkg/cargo/lib/rustlib/aarch64-unknown-linux-musl/lib/libstd-36c8b3e4cde7f9f5.rlib(std-36c8b3e4cde7f9f5.std.8518be91-cgu.13.rcgu.o): in function `std::sys::unix::fs::DirEntry::file_type':
std.8518be91-cgu.13:(.text._ZN3std3sys4unix2fs8DirEntry9file_type17h0024a0d0184b9af0E+0x80): undefined reference to `fstatat64'
/builder/shared-workdir/build/sdk/staging_dir/toolchain-aarch64_cortex-a53_gcc-12.3.0_musl/bin/../lib/gcc/aarch64-openwrt-linux-musl/12.3.0/../../../../aarch64-openwrt-linux-musl/bin/ld: /builder/shared-workdir/build/sdk/staging_dir/hostpkg/cargo/lib/rustlib/aarch64-unknown-linux-musl/lib/libstd-36c8b3e4cde7f9f5.rlib(std-36c8b3e4cde7f9f5.std.8518be91-cgu.13.rcgu.o): in function `std::sys::unix::fs::File::open_c':
std.8518be91-cgu.13:(.text._ZN3std3sys4unix2fs4File6open_c17hb3eaad2b27d5e957E+0x114): undefined reference to `open64'
/builder/shared-workdir/build/sdk/staging_dir/toolchain-aarch64_cortex-a53_gcc-12.3.0_musl/bin/../lib/gcc/aarch64-openwrt-linux-musl/12.3.0/../../../../aarch64-openwrt-linux-musl/bin/ld: /builder/shared-workdir/build/sdk/staging_dir/hostpkg/cargo/lib/rustlib/aarch64-unknown-linux-musl/lib/libstd-36c8b3e4cde7f9f5.rlib(std-36c8b3e4cde7f9f5.std.8518be91-cgu.13.rcgu.o): in function `std::sys::unix::fs::stat':
std.8518be91-cgu.13:(.text._ZN3std3sys4unix2fs4stat17h98081aaad028dbd1E+0x94): undefined reference to `stat64'
/builder/shared-workdir/build/sdk/staging_dir/toolchain-aarch64_cortex-a53_gcc-12.3.0_musl/bin/../lib/gcc/aarch64-openwrt-linux-musl/12.3.0/../../../../aarch64-openwrt-linux-musl/bin/ld: /builder/shared-workdir/build/sdk/staging_dir/hostpkg/cargo/lib/rustlib/aarch64-unknown-linux-musl/lib/libstd-36c8b3e4cde7f9f5.rlib(std-36c8b3e4cde7f9f5.std.8518be91-cgu.13.rcgu.o): in function `std::sys::unix::fs::lstat':
std.8518be91-cgu.13:(.text._ZN3std3sys4unix2fs5lstat17he0b1844f1e7f516bE+0x94): undefined reference to `lstat64'
collect2: error: ld returned 1 exit status
Signed-off-by: Nick Hainke <vincent@systemli.org>
Member
|
it needs to be fixed on rust side, see rust-lang/rust#111285 |
Member
|
simply adding |
PolynomialDivision
marked this pull request as draft
May 17, 2023 05:24
Member
|
cant believe it's passing, maybe i did something wrong in my env... |
PolynomialDivision
marked this pull request as ready for review
May 17, 2023 06:55
Member
|
if it works please consider adding it to RUST_CFLAGS: packages/lang/rust/rust-values.mk Line 11 in 3aaccd2 it affects all rust packages |
30 tasks
Member
|
this issue was actually fixed by #21296 so i guess we can close it now ;) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
_LARGEFILE64_SOURCE has to be defined in the source, or CFLAGS can be used to pass -D_LARGEFILE64_SOURCE to allow to keep using LFS64 definitions.
Fixes errors in the form of:
Maintainer: @lu-zero
Compile tested: CI
Run tested: no