#sdy add temporary pass in XLA SDY import to not allow meshes with different axis shapes. #415
+49
−19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
copybara-service
bot
force-pushed
the
test_735710081
branch
2 times, most recently
from
2ae9626 to
15dabf5
Compare
…fferent axis shapes. Longer term we should either error during propagation or just support propagating through different meshes, but until this is done www.github.com/jax-ml/jax/issues/26914 we can't look at doing this. As JAX first wants to make sure the lowered module never even has different meshes (but this is just a restriction JAX is imposing, that we don't have to impose in Shardy). PiperOrigin-RevId: 735710081
copybara-service
bot
force-pushed
the
test_735710081
branch
from
15dabf5 to
c83a080
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#sdy add temporary pass in XLA SDY import to not allow meshes with different axis shapes.
Longer term we should either error during propagation or just support propagating through different meshes, but until this is done www.github.com/jax-ml/jax/issues/26914 we can't look at doing this. As JAX first wants to make sure the lowered module never even has different meshes (but this is just a restriction JAX is imposing, that we don't have to impose in Shardy).