#sdy Insert sdy.all_reduce ops in -sdy-insert-explicit-reshards pass.
#420
+331
−170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
copybara-service
bot
force-pushed
the
test_737542586
branch
from
2b78aa4 to
0d7d3e5
Compare
…ass. If an op has a sharded reduction factor (e.g., contracting dim of dot) after reshards are inserted, we should insert a `sdy.all_reduce` with the axes that shard all reduction factors. In the future, when we have support for unreduced axes in TensorShardingAttr, we can have this pass insert a reshard from unreduced axes to replicated axes, and insert the all-reduce later on. PiperOrigin-RevId: 737966111
copybara-service
bot
force-pushed
the
test_737542586
branch
from
0d7d3e5 to
f27458f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#sdy Insert
sdy.all_reduceops in-sdy-insert-explicit-reshardspass.If an op has a sharded reduction factor (e.g., contracting dim of dot) after reshards are inserted, we should insert a
sdy.all_reducewith the axes that shard all reduction factors.In the future, when we have support for unreduced axes in TensorShardingAttr, we can have this pass insert a reshard from unreduced axes to replicated axes, and insert the all-reduce later on.