Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update comments. #426

Merged
merged 1 commit into from
Mar 19, 2025
Merged

Update comments. #426

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions shardy/dialect/sdy/transforms/propagation/op_sharding_rule_builder.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@ class OpShardingRuleBuilder {
FactorType factorType = FactorType::kPassThrough);

// Adds a pointwise factor for all dimensions of all operands/results that
// have rank at least 1. The factor type is determined by `predFactorType`.
// have rank at least 1. The factor type is determined by `getFactorType`.
OpShardingRuleBuilder& addPointwise(
ArrayRef<int64_t> shape,
std::function<FactorType(int64_t)> getFactorType = [](int64_t) {
Expand All @@ -96,7 +96,7 @@ class OpShardingRuleBuilder {

// Adds a pointwise factor for all dimensions that satisfy `pred` of all
// operands/results that have rank at least 1. The factor type is determined
// by `predFactorType`.
// by `getFactorType`.
OpShardingRuleBuilder& addPointwiseIf(
ArrayRef<int64_t> shape, std::function<bool(int64_t)> pred,
std::function<FactorType(int64_t)> getFactorType = [](int64_t) {
Expand All @@ -113,7 +113,7 @@ class OpShardingRuleBuilder {
onMismatchFn = [](int64_t dim, OpShardingRuleBuilder& builder) {});

// Adds a pointwise factor for all dimensions of all operands/results that
// have rank at least 1. The factor type is determined by `predFactorType`.
// have rank at least 1.
//
// Each dimension whose size in `inShape` and `outShape` is different, gets a
// `mismatchFactorType` factor type.
Expand Down