Create a compiler object on every call of Compiler::GetForPlatform(). #23436
+43
−52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
copybara-service
bot
force-pushed
the
test_734060671
branch
6 times, most recently
from
78fe175 to
56c7ffa
Compare
copybara-service
bot
force-pushed
the
test_734060671
branch
4 times, most recently
from
99a7742 to
f6557f2
Compare
copybara-service
bot
force-pushed
the
test_734060671
branch
5 times, most recently
from
5cf383c to
eb4b324
Compare
This is a first step in moving from xla::Compiler instance being a statically constructed singleton. We want to move all registrations to factories instead of singletons, so that every user creates their own compiler instance and sharing of instances becomes explicit. This should prevent race conditions and make code thread-safe. PiperOrigin-RevId: 743128681
copybara-service
bot
force-pushed
the
test_734060671
branch
from
eb4b324 to
0ba3b3b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create a compiler object on every call of Compiler::GetForPlatform().
This is a first step in moving from xla::Compiler instance being a statically constructed singleton. We want to move all registrations to factories instead of singletons, so that every user creates their own compiler instance and sharing of instances becomes explicit. This should prevent race conditions and make code thread-safe.