Make MakeBatchPointers use the kernel registry
#23853
Open
+344
−151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
copybara-service
bot
force-pushed
the
test_737892623
branch
4 times, most recently
from
c14ff31 to
f51d6b8
Compare
copybara-service
bot
force-pushed
the
test_737892623
branch
4 times, most recently
from
7a54aca to
d911d9a
Compare
- Moves `MakeBatchPointers` logic into backends/gpu/runtime since it's a runtime component.
- Defines trait for the MakeBatchPointers kernel in stream_executor/gpu/
- Moves the implementations of this kernel into stream_executor/{cuda|rocm} and registers them with the registry.
- Makes `MakeBatchPointers` retrieve the kernel by using the kernel registry.
- Add the kernel implementations as dependencies to the `all_runtime` targets for CUDA and ROCm.
PiperOrigin-RevId: 737892623
copybara-service
bot
force-pushed
the
test_737892623
branch
from
d911d9a to
0424172
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make
MakeBatchPointersuse the kernel registryMakeBatchPointerslogic into backends/gpu/runtime since it's a runtime component.MakeBatchPointersretrieve the kernel by using the kernel registry.all_runtimetargets for CUDA and ROCm.