Replace uses of deprecated Shape::rank() in OpenXLA with Shape::dimensions_size(), as we decided to stop using the "rank" term to mean the number of array dimensions.
#23944
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
copybara-service
bot
force-pushed
the
test_738479217
branch
6 times, most recently
from
6965376 to
3f747e4
Compare
copybara-service
bot
changed the title
Shape::rank() in OpenXLA.Shape::rank() in OpenXLA with Shape::dimensions_size(), as we decided to stop using the "rank" term to mean the number of array dimensions.
copybara-service
bot
force-pushed
the
test_738479217
branch
from
3f747e4 to
5e12d0b
Compare
…mensions_size()`, as we decided to stop using the "rank" term to mean the number of array dimensions. Initially I tried to replace `rank()` with `dimensions().size()`. However, I found that the change is unsafe in some cases as it changes the signedness of the value (from signed to unsigned). For example, due to C++ integer promotion, assuming the number of dimensions is 2, `rank() > -1` will be true (expected), but `dimensions().size() > -1` will be false (as -1 is converted to unsigned first). Therefore I decided to be safe and replace `rank()` with `dimensions_size()` instead. PiperOrigin-RevId: 738479217
copybara-service
bot
force-pushed
the
test_738479217
branch
from
5e12d0b to
4ce96ef
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace uses of deprecated
Shape::rank()in OpenXLA withShape::dimensions_size(), as we decided to stop using the "rank" term to mean the number of array dimensions.Initially I tried to replace
rank()withdimensions().size(). However, I found that the change is unsafe in some cases as it changes the signedness of the value (from signed to unsigned). For example, due to C++ integer promotion, assuming the number of dimensions is 2,rank() > -1will be true (expected), butdimensions().size() > -1will be false (as -1 is converted to unsigned first).Therefore I decided to be safe and replace
rank()withdimensions_size()instead.