PR #23056: Remove std::move for trivially copyable types #24022
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
Imported from GitHub PR #23056 Changes: - Removed unnecessary std::move calls for some trivially_copyable classes - Literal::CopyFrom expects a reference (&), not an r-value reference (&&). Removed std::move on the first parameter. Copybara import of the project: -- 6051f15 by Alexander Pivovarov <[email protected]>: Remove std::move for trivially copyable types Merging this change closes #23056 COPYBARA_INTEGRATE_REVIEW=#23056 from apivovarov:no_move_for_KernelMetadata 6051f15 PiperOrigin-RevId: 739114605
copybara-service
bot
force-pushed
the
test_739064828
branch
from
87b69ec to
8e58e1c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #23056: Remove std::move for trivially copyable types
Imported from GitHub PR #23056
Changes:
Copybara import of the project:
--
6051f15 by Alexander Pivovarov [email protected]:
Remove std::move for trivially copyable types
Merging this change closes #23056
FUTURE_COPYBARA_INTEGRATE_REVIEW=#23056 from apivovarov:no_move_for_KernelMetadata 6051f15