PR #24436: Fix variadic reduction shared memory estimation. #24498
+52
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
Imported from GitHub PR #24436 Currently, the logic is broken for variadic reductions with heterogeneous input types, since it always uses the first input's primitive type to estimate the shared memory buffer size. It should be summing up the primitive sizes instead. Also expand the comments a bit to explain better what's going on there. This should fix jax-ml/jax#27190. Copybara import of the project: -- 8bdb3fb by Johannes Reifferscheid <[email protected]>: Fix variadic reduction shared memory estimation. Currently, the logic is broken for variadic reductions with heterogeneous input types, since it always uses the first input's primitive type to estimate the shared memory buffer size. It should be summing up the primitive sizes instead. Also expand the comments a bit to explain better what's going on there. Merging this change closes #24436 FUTURE_COPYBARA_INTEGRATE_REVIEW=#24436 from jreiffers:variadic 8bdb3fb PiperOrigin-RevId: 743034494
copybara-service
bot
force-pushed
the
test_743034494
branch
from
932634b to
49df3cd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #24436: Fix variadic reduction shared memory estimation.
Imported from GitHub PR #24436
Currently, the logic is broken for variadic reductions with heterogeneous input types, since it always uses the first input's primitive type to estimate the shared memory buffer size. It should be summing up the primitive sizes instead.
Also expand the comments a bit to explain better what's going on there.
This should fix jax-ml/jax#27190.
Copybara import of the project:
--
8bdb3fb by Johannes Reifferscheid [email protected]:
Fix variadic reduction shared memory estimation.
Currently, the logic is broken for variadic reductions with heterogeneous
input types, since it always uses the first input's primitive type to
estimate the shared memory buffer size. It should be summing up the
primitive sizes instead.
Also expand the comments a bit to explain better what's going on there.
Merging this change closes #24436
FUTURE_COPYBARA_INTEGRATE_REVIEW=#24436 from jreiffers:variadic 8bdb3fb