[XLA:GPU] Remove second run of SortRewriter from the GPU pipeline. #24500
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
copybara-service
bot
force-pushed
the
test_743005885
branch
from
b38d0bb to
5a2ccd4
Compare
This second run was possibly meant to rewrite the sorts created by DynamicPadder. But there are two issues here: We would need to run SortRewriter before StableSortExpander, and SortRewriter currently doesn't support sorting pairs where the key is not an unsigned integer. Add a pass order test to verify that SortRewriter runs before ComparisonExpander and StableSortExpander, as otherwise we would not match the expanded patterns. PiperOrigin-RevId: 743095864
copybara-service
bot
force-pushed
the
test_743005885
branch
from
5a2ccd4 to
294c9dc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[XLA:GPU] Remove second run of SortRewriter from the GPU pipeline.
This second run was possibly meant to rewrite the sorts created by
DynamicPadder. But there are two issues here: We would need to run SortRewriter
before StableSortExpander, and SortRewriter currently doesn't support sorting
pairs where the key is not an unsigned integer.
Add a pass order test to verify that SortRewriter runs before
ComparisonExpander and StableSortExpander, as otherwise we would not match the
expanded patterns.