Clean up Read() in file_system:
#24520
Merged
+26
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
copybara-service
bot
force-pushed
the
test_743164950
branch
from
0e89c04 to
c19db45
Compare
- Add a default implementation of the deprecated `Read()` in the base class to enable subclasses to migrate to implementing the new, safe `Read()`. - Use `ABSL_DEPRECATE_AND_INLINE()` to enable bots to fix existing call sites. - Remove the redundant size parameter from the new `Read()` as it can be inferred from the `Span` parameter. PiperOrigin-RevId: 743703411
copybara-service
bot
force-pushed
the
test_743164950
branch
from
c19db45 to
b670576
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clean up
Read()infile_system:Read()in the base class to enable subclasses to migrate to implementing the new, safeRead().ABSL_DEPRECATE_AND_INLINE()to enable bots to fix existing call sites.Read()as it can be inferred from theSpanparameter.