Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenZFS 2.2.7 doest not compile with Linux 6.14-rc1 #17025

Open
KrzysztofHajdamowicz opened this issue Feb 4, 2025 · 1 comment
Open

OpenZFS 2.2.7 doest not compile with Linux 6.14-rc1 #17025

KrzysztofHajdamowicz opened this issue Feb 4, 2025 · 1 comment
Labels
Type: Defect Incorrect behavior (e.g. crash, hang)

Comments

@KrzysztofHajdamowicz
Copy link

System information

Type Version/Name
Distribution Name Proxmox + custom kernel
Distribution Version 8
Kernel Version 6.14-rc1
Architecture x86_64
OpenZFS Version 2.2.7

Describe the problem you're observing

OpenZFS 2.2.7 does not compile with kernel 6.14-rc1

  CC [M]  os/linux/zfs/zpl_file_range.o
os/linux/zfs/zpl_ctldir.c:204:27: error: initialization of 'int (*)(struct inode *, const struct qstr *, struct dentry *, unsigned int)' from incompatible pointer type 'int (*)(struct dentry *, unsigned int)' [-Werror=incompatible-pointer-types]
  204 |         .d_revalidate   = zpl_snapdir_revalidate,
      |                           ^~~~~~~~~~~~~~~~~~~~~~
os/linux/zfs/zpl_ctldir.c:204:27: note: (near initialization for 'zpl_dops_snapdirs.d_revalidate')

Describe how to reproduce the problem

Issue appears when compiling kernel 6.14- there was no issue with kernel 6.13.

To try it at your own:

  1. Grab pve-kernel repo https://github.com/KrzysztofHajdamowicz/pve-kernel
  2. git submodule init && git submodule update
  3. cd submodules/ubuntu-kernel && git remote add github https://github.com/KrzysztofHajdamowicz/mirror_ubuntu-kernels.git
  4. cd submodules/ubuntu-kernel && git checkout github/build
  5. Use https://github.com/KrzysztofHajdamowicz/pve-kernel-zfsonlinux as submodules/zfsonlinux (note upstream submodule that point to openzfs/zfs repo)
  6. make
  7. Result is: build.txt

6.14 (and even 6.13) is too new to be mentioned as supported in release notes but FIY some code changes will be needed in the future 🙂

@KrzysztofHajdamowicz KrzysztofHajdamowicz added the Type: Defect Incorrect behavior (e.g. crash, hang) label Feb 4, 2025
@robn
Copy link
Member

robn commented Feb 5, 2025

@KrzysztofHajdamowicz #17026 posted to add support for 6.14. Once that kernel is released and support on master looks good, we'll likely backport it for a 2.2.x release. In the meantime, it's a very small amount of change, so if you're in the mood to test, you might like to apply those two patches yourself to 2.2.7 and give them a try.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Defect Incorrect behavior (e.g. crash, hang)
Projects
None yet
Development

No branches or pull requests

2 participants