-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Linux 6.13 compat #16831
Linux 6.13 compat #16831
Conversation
No changes from 6.12 🤯 Sponsored-by: https://despairlabs.com/sponsor/ Signed-off-by: Rob Norris <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Astonishingly, there appear to be NO CHANGES required.
😮 wow hopefully that holds true for the rest of the RCs!
Test suite passed against 6.13-rc2. |
Test suite passed against 6.13-rc3. |
Test suite passed against 6.13-rc5. |
Alas, rc6 broken twice. The first run had a deadlock between |
rc5 crashed too
I'll try again, but I'm also low-key wondering if we've changed something (I'm always running these tests against |
And here's a crash on rc5,
I'll try to reproduce it more reliably, because I still can't really guess if its a recent regression on our side, or it just didn't show up in earlier 6.13 runs because its hard to hit. |
Any clue about whether this is a regression on our side? |
Uncertain. I've hit that Mostly, I've had almost no time to look into it, and won't really for at least another week or so - I'm heading to a conference and then a short vacation on Saturday. |
hey @robn I was briefly trying this again but with 6.12.10-gentoo, and I appear to have experienced a crash. I was in the cli doing my thing and the display blanked and my system restarted. |
(coming from NixOS) |
yeah i think should probably be patchdiff --git a/module/Makefile.in b/module/Makefile.in
index f76e94afa..c735f0df7 100644
--- a/module/Makefile.in
+++ b/module/Makefile.in
@@ -87,7 +87,7 @@ modules_uninstall-Linux-legacy:
KMODDIR := $(INSTALL_MOD_PATH)/lib/modules/@LINUX_VERSION@
modules_install-Linux: modules_uninstall-Linux-legacy
@# Install the kernel modules
- $(MAKE) -C @LINUX_OBJ@ M="$$PWD" modules_install \
+ $(MAKE) -f @LINUX_OBJ@/Makefile M="$$PWD" modules_install \
INSTALL_MOD_PATH=$(INSTALL_MOD_PATH) \
INSTALL_MOD_DIR=$(INSTALL_MOD_DIR) \
$(if @KERNEL_ARCH@,ARCH=@KERNEL_ARCH@) \ upstream change: torvalds/linux@13b2548, torvalds/linux@bad6beb |
@robn Hi, any news on this issue, as 6.14-rc1 is out ;-) |
I just finished a full ZTS run overnight on 6.13.1, no complaints. I'll do another run overnight tonight, but if that comes up clean too then idk, move on to 6.14? |
@robn forget my comment I highlighted you with. I was using this patch set as a "fork" not as a patch. once I used it as a patch, I've had zero crashes. I suspect most feedback you may have got about instability is in this same basket. I've been using this as a patch rock solid on 6.13 and 6.13.1 gentoo and xanmod patch sets. |
my setup has 3 pools: 1 SSD / 2.3, 2 disk mirror /home 2.3, and a large single disk pool running 2.2. The large pool ill upgrade when it appears that more distributions and tools upgrade to 2.3 or higher. no crashes no issues. probably I'm gonna wait till the next rc to test 6.14. |
I'm going to close this out (not that there's any actual change here anyway). Preliminary support for 6.14 has been merged already (#17026), so we can continue testing on anything. I'll try to get more test runs against 6.13.X and 6.14-rcY over the next few days, as my test rig has availability (a full run is up around ~12h for me these days, and I have my own changes to test too, so new kernels only get looked at when its idle). Please report anything new in a new issue. Thanks! |
yeah that makes sense I was considering suggesting this to you in the possible chance you forgot about this being kinda an obsolete pr (already imp) |
Motivation and Context
Regular prep for new kernel series.
Description
Astonishingly, there appear to be NO CHANGES required. So for the moment, this PR is simply a placeholder for anything that might come up during the 6.13-rc series.
(I wouldn't normally bump META, but I had to commit something to be allowed to create a PR).
How Has This Been Tested?
Full ZTS runs on 6.13-rc1, rc2, rc3 and rc5 completed successfully.
Types of changes
Checklist:
Signed-off-by
.