Skip to content

Conversation

@amotin
Copy link
Member

@amotin amotin commented Nov 25, 2025

ddt_lookup() is a very busy code under a highly congested global lock. Anything we can save here is very important.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Quality assurance (non-breaking change which makes the code more robust against bugs)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Library ABI change (libzfs, libzfs_core, libnvpair, libuutil and libzfsbootenv)
  • Documentation (a change to man pages or other documentation)

Checklist:

ddt_lookup() is a very busy code under a highly congested global
lock.  Anything we can save here is very important.

Signed-off-by: Alexander Motin <[email protected]>
Copy link
Member

@robn robn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, nice.

(also you reminded me that I have a patch lying around here somewhere to help generate this stat boilerplate; must find it and polish it up sometime)

@amotin amotin added the Status: Code Review Needed Ready for review and testing label Nov 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Status: Code Review Needed Ready for review and testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants