Skip to content

Small changes for mindtouch #213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 8, 2024
Merged

Small changes for mindtouch #213

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e57f6de
Fix typing
benoit74 Nov 8, 2024
f5f0412
Add standard log format displaying thread name
benoit74 Nov 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/zimscraperlib/download.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,13 +177,13 @@ def stream_file(
fpath: pathlib.Path | None = None,
byte_stream: IO[bytes] | None = None,
block_size: int | None = 1024,
proxies: dict | None = None,
proxies: dict[str, str] | None = None,
max_retries: int | None = 5,
headers: dict[str, str] | None = None,
session: requests.Session | None = None,
*,
only_first_block: bool | None = False,
) -> tuple[int, requests.structures.CaseInsensitiveDict]:
) -> tuple[int, requests.structures.CaseInsensitiveDict[str]]:
"""Stream data from a URL to either a BytesIO object or a file
Arguments -
fpath - Path of the file where data is sent
Expand Down
3 changes: 3 additions & 0 deletions src/zimscraperlib/logging.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,9 @@
from zimscraperlib.constants import NAME

DEFAULT_FORMAT = "[%(name)s::%(asctime)s] %(levelname)s:%(message)s"
DEFAULT_FORMAT_WITH_THREADS = (
"[%(name)s::%(threadName)s::%(asctime)s] %(levelname)s:%(message)s"
)
VERBOSE_DEPENDENCIES = ["urllib3", "PIL", "boto3", "botocore", "s3transfer"]


Expand Down