adds router posture responses (ha support) #816
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
andrewpmartinez
commented
Oct 6, 2025
andrewpmartinez
commented
- adds ability to submit posture to controller or router based on router capabilities
- adds new ToTP MFA JWT token type for MFA posture checks post-login
- adds ability to submit posture to controller or router based on router capabilities - adds new ToTP MFA JWT token type for MFA posture checks post-login
plorenz
reviewed
Oct 6, 2025
| SdkInfo sdkInfo = 7; | ||
| TotpToken totpToken = 8; | ||
| }; | ||
|
|
There was a problem hiding this comment.
What's the advantage of wrapping this in a type, instead of just using string?
plorenz
reviewed
Oct 6, 2025
| Token: typedResp.TotpToken, | ||
| }, | ||
| }, | ||
| }) |
There was a problem hiding this comment.
Maybe add a default with an ERROR here, so we hopefully notice if a new type is introduced and the case isn't handled yet?
plorenz
reviewed
Oct 6, 2025
| TotpToken string //should be a signed, API Session scoped JWT. See common.TotpClaims | ||
| Id *string | ||
| } | ||
|
|
There was a problem hiding this comment.
Should probably be using pointer receivers, see staticcheck error below
plorenz
reviewed
Oct 6, 2025
| } | ||
| return edgeCh | ||
| } | ||
|
|
There was a problem hiding this comment.
Would it make sense to have a container message if you're sending multiple responses?
plorenz
approved these changes
Oct 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.