Skip to content

fix(auth): add missing access checks to server_sync_status #79

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(auth): add missing access checks to server_sync_status #79

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 34 additions & 3 deletions views/server_sync_status.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,10 +21,41 @@
require('views/error404.php');
die;
}

$server_admin = $active_user->admin_of($server);
$account_admin_on_this_server = false;

if (!$active_user->admin && !$server_admin) {
// If not global or server admin, check if user is admin of at least one account on this server
foreach ($server->list_accounts() as $acct) {
if ($active_user->admin_of($acct)) {
$account_admin_on_this_server = true;
break;
}
}
}

if (!$active_user->admin && !$server_admin && !$account_admin_on_this_server) {
require('views/error403.php');
die;
}

$page = new PageSection('server_sync_status_json');
$page->set('sync_status', $server->sync_status);
$page->set('last_sync', $server->get_last_sync_event());
$page->set('pending', count($server->list_sync_requests()) > 0);
$page->set('accounts', $server->list_accounts());
$page->set('last_sync_event', $server->get_last_sync_event());
$page->set('pending', $server->sync_is_pending());

// Only show account inventory to privileged viewers.
// - Global admin or server admin: full list
// - Account admin: only accounts they administer
if ($active_user->admin || $server_admin) {
$accounts = $server->list_accounts();
} else {
$accounts = array_filter($server->list_accounts(), function ($acct) use ($active_user) {
return $active_user->admin_of($acct);
});
}
$page->set('accounts', $accounts);

header('Content-type: application/json; charset=utf-8');
echo $page->generate();