Skip to content

Conversation

camilamacedo86
Copy link
Contributor

@camilamacedo86 camilamacedo86 commented Oct 14, 2025

Description

  • Promote Single Own Feature Gate GA
  • Promote the Config spec to the public/stable API. Without the spec.config.inline.watchNamespace field, there’s no place to declare which namespace the operator should watch, so the controller can only ever assume the default AllNamespaces behaviour. That’s why we need config available in the GA schema: it’s the user-facing knob that flips the controller into Single/Own namespace mode. Example:
    Config: &ocv1.ClusterExtensionConfig{
    ConfigType: ocv1.ClusterExtensionConfigTypeInline,
    Inline: &apiextensionsv1.JSON{
    Raw: []byte(`{"watchNamespace": "` + expectedWatchNamespace + `"}`),
    },
    },

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

@camilamacedo86 camilamacedo86 requested a review from a team as a code owner October 14, 2025 11:22
@openshift-ci openshift-ci bot requested a review from joelanford October 14, 2025 11:22
Copy link

openshift-ci bot commented Oct 14, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign kevinrizza for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot requested a review from oceanc80 October 14, 2025 11:22
@camilamacedo86 camilamacedo86 changed the title Promote Single Own Feature Gate to GA ✨ Promote Single Own Feature Gate to GA Oct 14, 2025
Copy link

netlify bot commented Oct 14, 2025

Deploy Preview for olmv1 ready!

Name Link
🔨 Latest commit 64f8896
🔍 Latest deploy log https://app.netlify.com/projects/olmv1/deploys/68ef530b6f92b40008ba30d5
😎 Deploy Preview https://deploy-preview-2268--olmv1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@camilamacedo86 camilamacedo86 changed the title ✨ Promote Single Own Feature Gate to GA ✨ Promote Single Own Feature Gate to GA (OPRUN-4098) Oct 14, 2025
@camilamacedo86 camilamacedo86 changed the title ✨ Promote Single Own Feature Gate to GA (OPRUN-4098) WIP: ✨ Promote Single Own Feature Gate to GA (OPRUN-4098) Oct 14, 2025
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 14, 2025
@camilamacedo86 camilamacedo86 force-pushed the promote-single-own-feature branch from 6ff525c to 6fb12ed Compare October 14, 2025 12:09
@camilamacedo86 camilamacedo86 changed the title WIP: ✨ Promote Single Own Feature Gate to GA (OPRUN-4098) WIP: ✨ Promote Single Own Feature Gate AND Config spec in the CR to GA (OPRUN-4098) Oct 14, 2025
@camilamacedo86 camilamacedo86 changed the title WIP: ✨ Promote Single Own Feature Gate AND Config spec in the CR to GA (OPRUN-4098) ✨ Promote Single Own Feature Gate AND Config spec in the CR to GA (OPRUN-4098) Oct 14, 2025
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 14, 2025
@camilamacedo86 camilamacedo86 changed the title ✨ Promote Single Own Feature Gate AND Config spec in the CR to GA (OPRUN-4098) WIP: ✨ Promote Single Own Feature Gate AND Config spec in the CR to GA (OPRUN-4098) Oct 14, 2025
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 14, 2025
Copy link

codecov bot commented Oct 14, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 73.00%. Comparing base (9eac616) to head (64f8896).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2268      +/-   ##
==========================================
+ Coverage   72.93%   73.00%   +0.06%     
==========================================
  Files          88       88              
  Lines        8743     8743              
==========================================
+ Hits         6377     6383       +6     
+ Misses       1951     1946       -5     
+ Partials      415      414       -1     
Flag Coverage Δ
e2e 40.40% <ø> (+1.02%) ⬆️
experimental-e2e 46.79% <ø> (+0.07%) ⬆️
unit 58.11% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@camilamacedo86 camilamacedo86 changed the title WIP: ✨ Promote Single Own Feature Gate AND Config spec in the CR to GA (OPRUN-4098) ✨ Promote Single Own Feature Gate AND Config spec in the CR to GA (OPRUN-4098) Oct 14, 2025
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 14, 2025
!!! important
Currently, OLM 1.0 does not support the installation of extensions that use webhooks or that target a single or specified set of namespaces.
OLM 1.0 supports installing extensions that define webhooks. Targeting a single or specified set of namespaces is handled by the `SingleOwnNamespaceInstallSupport` feature gate, which is enabled by default.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to be conflated with #2267? i.e. this is changing the line for both the Webhook and Single/OwnNamespace features.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought the same when I was doing the PR. But let’s merge these in sequence: one first, then the other. The follow-up PR can be rebased and we’ll adjust the doc text—conflicts are only in the docs. I prefer keeping two PRs since they address different goals.

@camilamacedo86
Copy link
Contributor Author

/hold

We might need to discuss more how to work with see: #2267 (comment)

So it si WIP

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 14, 2025
@camilamacedo86 camilamacedo86 force-pushed the promote-single-own-feature branch from 62736c1 to 64f8896 Compare October 15, 2025 07:53
@camilamacedo86
Copy link
Contributor Author

camilamacedo86 commented Oct 15, 2025

I think we can

/hold cancel

All comments are addressed
I am lookling for to see if we are satisfied with the default approach.

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 15, 2025
@tmshort
Copy link
Contributor

tmshort commented Oct 15, 2025

Is there an order for this with respect to #2267?

@camilamacedo86
Copy link
Contributor Author

camilamacedo86 commented Oct 15, 2025

Is there an order for this with respect to #2267?

No. I do think so.
But as we spoke, I think we will need to make changes here.
-> Do not enable feature flag by default
-> use the helm values to set those

/hold

until 🔨 meeting

@camilamacedo86 camilamacedo86 added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants