-
Notifications
You must be signed in to change notification settings - Fork 66
✨ Promote Single Own Feature Gate AND Config spec in the CR to GA (OPRUN-4098) #2268
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
✨ Promote Single Own Feature Gate AND Config spec in the CR to GA (OPRUN-4098) #2268
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
✅ Deploy Preview for olmv1 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
6ff525c
to
6fb12ed
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2268 +/- ##
==========================================
+ Coverage 72.93% 73.00% +0.06%
==========================================
Files 88 88
Lines 8743 8743
==========================================
+ Hits 6377 6383 +6
+ Misses 1951 1946 -5
+ Partials 415 414 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
!!! important | ||
Currently, OLM 1.0 does not support the installation of extensions that use webhooks or that target a single or specified set of namespaces. | ||
OLM 1.0 supports installing extensions that define webhooks. Targeting a single or specified set of namespaces is handled by the `SingleOwnNamespaceInstallSupport` feature gate, which is enabled by default. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems to be conflated with #2267? i.e. this is changing the line for both the Webhook and Single/OwnNamespace features.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought the same when I was doing the PR. But let’s merge these in sequence: one first, then the other. The follow-up PR can be rebased and we’ll adjust the doc text—conflicts are only in the docs. I prefer keeping two PRs since they address different goals.
/hold We might need to discuss more how to work with see: #2267 (comment) So it si WIP |
62736c1
to
64f8896
Compare
I think we can /hold cancel All comments are addressed |
Is there an order for this with respect to #2267? |
No. I do think so. /hold until 🔨 meeting |
Description
operator-controller/internal/operator-controller/applier/provider_test.go
Lines 229 to 234 in 9eac616
Reviewer Checklist