Skip to content

Let’s style this thing! #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 58 commits into from
May 16, 2013
Merged

Let’s style this thing! #37

merged 58 commits into from
May 16, 2013

Conversation

rastersize
Copy link
Contributor

The app could look, erhm, prettier. So let’s make it prettier! One could see this issue as a part of #35.

End result should look something like:
The questions list The question view for a “normal” question

Tasks

General

  • Create a sprite sheet for all the image assets.
  • Export all the image assets.
  • Change the font to Avenir Next, see pull request Use Avenir Next as font for the app #29 and the tasks for each section. In progress

Questions

  • Rework the single question table view cell. In progress
    • See if we can get tags in there.
    • See if we can get last modified date in there.
  • Remove “Heat” button as that is now inline.
  • Improve the “cool” color scheme.
  • Improve the “bad” color scheme.
  • Change the font to Avenir Next, see pull request Use Avenir Next as font for the app #29. In progress

Question

  • Change the question header view to use our background image.
  • Style the vote up/down buttons.
  • Set the link color to #0069bf (0x0069bf; HSB: 207,100,75).
  • Set the color of comments, poster and score to link color to #404040 (0x 404040; HSB: 0,0,25).
  • Try to get last modified date into the design.
  • Change the font to Avenir Next, see pull request Use Avenir Next as font for the app #29.

Tags browser

Activity

Users profile search

User profile

Tab bar

  • Change the font to Avenir Next, see pull request Use Avenir Next as font for the app #29. Postponed as there is an issue in AKTabBarController, the version which allows us to set the font also has a bug which (is supposed to have been fixed, but it isn’t) pushed the contained view controller’s view down by the height of the status bar.

rastersize added 8 commits May 7, 2013 19:32
@rastersize
Add image assets for posts.
637526a 
Signed-off-by: Aron Cedercrantz <[email protected]>
@rastersize
Move the assets file and add a few more images to it.
ee1ee68 
Signed-off-by: Aron Cedercrantz <[email protected]>
@rastersize
Add a log of exported assets.
a6e85a0 
Signed-off-by: Aron Cedercrantz <[email protected]>
@rastersize
Merge branch 'master' into feature/styling
6d13b89 
* master:
  Some more UI improvements
  UI improvements in the built in web browser
  Change bio cell's height.
  Add mockup form, return to login view on signup.
  UI improvements to logout buutton and links in user bio is now opened in built in web browser
  Add registration option to login view and load from storyboard in container.
  Add static table view to storyboard and change controllers for signup.
  Fixed a bug in OPFProfileContainerController which made the view to large for iPhone1-iPhone4s
@rastersize
Merge branch 'master' into feature/styling
133dc82 
* master:
  UI Improvements in signupview
@rastersize
Merge branch 'master' into feature/styling
5b2fe47 
* master:
  Add note about two methods which must not be called from main thread.
  Commented out the PostQuestion view in master while I'm fixing a bug
  Added view and controllers for posting questions. Functionality is not fully implemented yet.
@rastersize
Add more image assets.
24900c2 
- Answer header background.
- Vote up/down highlighted buttons.
- Also fixes a few minor visual issues with the question metadata
backgrounds.

Signed-off-by: Aron Cedercrantz <[email protected]>
@rastersize
Add background image for question header and score.
b0e5cc9 
- Also tweaks the other images a bit.

Signed-off-by: Aron Cedercrantz <[email protected]>
@ghost ghost assigned rastersize May 8, 2013
rastersize added 15 commits May 8, 2013 16:23
@rastersize
Merge branch 'master' into feature/styling
8c82c41 
* master:
  Fixed a bug in the postQuestionView. Will fix a nice animation later
@rastersize
Remove heat mode.
d2011ce 
Signed-off-by: Aron Cedercrantz <[email protected]>
@rastersize
Fix question cell not having a background.
3f1cc83 
Signed-off-by: Aron Cedercrantz <[email protected]>
@rastersize
Add images to Xcode project.
33f1071 
Signed-off-by: Aron Cedercrantz <[email protected]>
@rastersize
Add UIFont category from feature/avenir-next.
4265782 
Signed-off-by: Aron Cedercrantz <[email protected]>
@rastersize
Change a few elements to use app font.
f63d219 
Signed-off-by: Aron Cedercrantz <[email protected]>
@rastersize
Begin styling of questions cells.
6a61317 
Signed-off-by: Aron Cedercrantz <[email protected]>
@rastersize
Merge branch 'master' into feature/styling
be71c04 
* master:
  Added db access for PostQuestionController
@rastersize
Fix (in a way) the question cell label looking funny.
f98fb04 
- Why U give me so much trouble UILabel/UITextView!

Signed-off-by: Aron Cedercrantz <[email protected]>
@rastersize
Hide navigation bar while searching.
688f70b 
Signed-off-by: Aron Cedercrantz <[email protected]>
@rastersize
Refactor out the app background color to a category.
171d349 
Signed-off-by: Aron Cedercrantz <[email protected]>
@rastersize
Refactor presentation of a question.
f9d336e 
Signed-off-by: Aron Cedercrantz <[email protected]>
@rastersize
Change the presentation animation of “ask question”.
18357dd 
- Such a view is not part of the hierarchical view “chain” but rather a
separate mode. Thus a modal presentation is the right way to go. By
utilizing.
- Known issue: the runtime is complaining that we are dismissing
something while we present this. I honestly do not know or understand
what the something else should be as it’s only one view controller being
presented…

Signed-off-by: Aron Cedercrantz <[email protected]>
@rastersize
Change so database access log statements are opt-in.
0b1f388 
- Just change the `0` to a `1` in the macro define statement (@jesjos).

Signed-off-by: Aron Cedercrantz <[email protected]>
@rastersize
Change log statements to use DLog instead of NSLog
2a34254 
- DLog will only output info in DEBUG mode and will also automatically
state in which method it’s being called from.

Signed-off-by: Aron Cedercrantz <[email protected]>
@rastersize
Copy link
Contributor Author

So the commit between (inclusive) 171d349 and 2a34254 were meant to be committed to master… FML.

rastersize added 5 commits May 14, 2013 10:10
@rastersize
Merge branch 'master' into feature/styling
a25ca71 
* master:
  Added a check so all required fields inkl. email is correctly filled in the sign up view
  Keyboard is now is now dismissed when return key is pressed in the login view
  User can now register in DB
  Added update query to update DB with a new user. Still need to change the sign-up user interface
  Database is now updated when user post comments
  The database is now updated when writing answers to specific posts
  Added answer button to the QuestionView
  All tags are now parsed and tranformed to the correct format in OPFPostQuestionViewController
  Added animation to/from the postQuestionView
  Functionality added to update the database with questions.
  Deleted duplicates of OPFWebViewController and OPFWebView
  Added calculations for updates of the database with questions
  Added class that will insert data in database

Signed-off-by: Aron Cedercrantz <[email protected]>

Conflicts:
	Code Stream.xcodeproj/project.pbxproj
	Code Stream/OPFCommentsViewController.m
	Code Stream/OPFPostQuestionViewController.m
	Code Stream/OPFQuestionsViewController.m
@rastersize
Merge branch 'master' into feature/styling
7575623 
* master:
  Fix all the new warnings triggered by newly turned on warnings.
  Turn on a bunch of warnings.
  Fix that +indexString warning.
@rastersize
Tweak question metadata shadow.
da34980 
Signed-off-by: Aron Cedercrantz <[email protected]>
@rastersize
Fix shadowing a local variable warning.
31c1985 
Signed-off-by: Aron Cedercrantz <[email protected]>
@rastersize
Refactor show ask a question view.
c4523ac 
Signed-off-by: Aron Cedercrantz <[email protected]>
rastersize added 26 commits May 14, 2013 15:44
@rastersize
Add voting button images.
2c1b103 
Signed-off-by: Aron Cedercrantz <[email protected]>
@rastersize
Add an answers separator section header view.
2431acf 
Signed-off-by: Aron Cedercrantz <[email protected]>
@rastersize
Add UIImage view categories for scaling, resizing and scores.
10f04ef 
Signed-off-by: Aron Cedercrantz <[email protected]>
@rastersize
Update question header view backgrounds.
106f075 
Signed-off-by: Aron Cedercrantz <[email protected]>
@rastersize
Use new score image category.
662fe58 
Signed-off-by: Aron Cedercrantz <[email protected]>
@rastersize
Remove some extra chars from a few strings.
151b311 
Signed-off-by: Aron Cedercrantz <[email protected]>
@rastersize
Refactor the OPFQuestionHeaderView.
75f170b 
- One step closer to the mockups.

Signed-off-by: Aron Cedercrantz <[email protected]>
@rastersize
Organize categories a bit.
0830b5f 
Signed-off-by: Aron Cedercrantz <[email protected]>
@rastersize
Add question header metadata background.
89fdb49 
Signed-off-by: Aron Cedercrantz <[email protected]>
@rastersize
Add separator cell between post.
9c61fae 
Signed-off-by: Aron Cedercrantz <[email protected]>
@rastersize
OK Xcode, I’ll let you do this. Now that you’ve tried ~100 times.
324aaf3 
Signed-off-by: Aron Cedercrantz <[email protected]>
@rastersize
Merge branch 'master' into feature/styling
4f0fe1e 
* master: (22 commits)
  Fix a major name mangling problem.
  Auxiliary db is now updated when new posts and users are added
  Remove SwipeView from Podfile.
  Fix hidding footer labels on missing matches.
  Add displaying of related tags.
  Add wrapper around fixed footer.
  Add removing tag selection functionality.
  Display sub-controller showing selected tags.
  Add sub-controller handling selected tags.
  Add fixed header scrollview to collection view's wrapper.
  Fix passing tagNames into query and externalize getTagNames.
  Pass query and search string into questions controller.
  Load questions by tags and render footer.
  Change tag-browser footer and add to collection-view.
  Add tag-browser footer to collection view.
  Add footer for tag-browser showing question-match-count.
  Add SwipeView to podfile.
  Overwrite setter and move IBOutlet setting to view.
  Add collection header for selection state.
  Add collection view header and change insets.
  ...

Signed-off-by: Aron Cedercrantz <[email protected]>

Conflicts:
	Code Stream.xcodeproj/project.pbxproj
	Code Stream/OPFCommentsViewController.m
	Code Stream/OPFPostQuestionViewController.m
	Code Stream/OPFQuestionViewController.m
	Code Stream/OPFQuestionsViewController.m
@rastersize
Add padding between user name/score and avatar.
f1b0049 
Signed-off-by: Aron Cedercrantz <[email protected]>
@rastersize
Fix variable not being zero initialized.
a920586 
- Better safe than sorry.

Signed-off-by: Aron Cedercrantz <[email protected]>
@rastersize
Change so that it’s theoretically possible to show q body.
d7b057f 
- Disabled right now as we would need to strip the content like crazy.

Signed-off-by: Aron Cedercrantz <[email protected]>
@rastersize
Add ability to conditionally disable token shadow.
6547b34 
Signed-off-by: Aron Cedercrantz <[email protected]>
@rastersize
Set a default item size for tokens.
f806137 
Signed-off-by: Aron Cedercrantz <[email protected]>
@rastersize
Replace GCTagList with our UICollectionView based solution.
0c13182 
Signed-off-by: Aron Cedercrantz <[email protected]>
@rastersize
Fix the missing bottom border of the tags cell.
303dfc6 
Signed-off-by: Aron Cedercrantz <[email protected]>
@rastersize
Change token font to app font.
6b17879 
Signed-off-by: Aron Cedercrantz <[email protected]>
@rastersize
Change font of “insert new token” buttons to app font.
76b43ce 
Signed-off-by: Aron Cedercrantz <[email protected]>
@rastersize
Change font of login view controller to app font.
1595a72 
Signed-off-by: Aron Cedercrantz <[email protected]>
@rastersize
Merge branch 'master' into feature/styling
f361fba 
* master:
  Fixed a compile error
  Added user login to OPFPostQuestionView if user is not logged in
  Added user login to OPFPostQuestionView if user is not logged in

Signed-off-by: Aron Cedercrantz <[email protected]>

Conflicts:
	Code Stream/OPFPostQuestionViewController.m
@rastersize
Change font and colors of post metadata.
babc248 
Signed-off-by: Aron Cedercrantz <[email protected]>
@rastersize
Merge branch 'master' into feature/styling
118659c 
* master:
  Last commit was incomplete
  Design polishing
  Try to fix graphics
  Sorting is hooked into View View is drawn correctly
  Hookup of SortOrderControl with ViewController
  ScrollView works
  Both Headers inserted correctly and bouncable
  Encapsulate search bar and sorting controls in a view
  Segment control for search order Button to get to Segment Control

Signed-off-by: Aron Cedercrantz <[email protected]>

Conflicts:
	Code Stream.xcodeproj/project.pbxproj
	Code Stream/OPFQuestionsViewController.m
	Code Stream/OPFQuestionsViewController.xib
@rastersize
Fix some lingering merge issues.
c2aff08 
Signed-off-by: Aron Cedercrantz <[email protected]>
rastersize added a commit that referenced this pull request May 16, 2013
@rastersize
Merge pull request #37 from opfo/feature/styling
3ded9e1 
Style certain parts of the app (part of #35).
@rastersize rastersize merged commit 3ded9e1 into master May 16, 2013
@rastersize
Copy link
Contributor Author

I’m tired of merge conflicts, so here we go merge pull request time™

@rastersize rastersize mentioned this pull request May 16, 2013
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@rastersize rastersize

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@rastersize