Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs/clarify static lease register #8028

Closed
wants to merge 2 commits into from
Closed

Docs/clarify static lease register #8028

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d796ea8
Docs: Clarify the type of static lease registered by unbound
Vaarlion Oct 23, 2024
ea310fe
Merge branch 'opnsense:master' into docs/Clarify_static_lease_register
Vaarlion Oct 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/opnsense/mvc/app/controllers/OPNsense/Unbound/forms/general.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,7 @@
<type>checkbox</type>
<help>
<![CDATA[If this option is set, then DHCP static mappings will be registered in Unbound, so that their name can be resolved.
DHCP lease without a specified static ip cannot be register.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Static mappings are not leases. IP addresses are more or less implied for DNS to resolve but clarifying it in the first sentence wouldn’t hurt I suppose for all those who do read…

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does DHCP static mapping which doesn't contain a static ip will not be registered sound more accurate ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You want to make it affirmative:

… static mappings with an IP address will be registered…

You should also set the domain in <a href="/system_general.php">System: Settings: General</a> to the proper value.]]>
</help>
</field>
Expand Down