js/opnsense_ui: Add checkmark to SimpleActionButton on success #8310
+24
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Frankly I'm not a fan of this behaviour: the spinner should spin while work is in progress. On abort the spinner should stop and show an API error or other message if relevant. The default outcome is success and indicating this further seems spurious. Just my 2 cents here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Apply button does not give any feedback on success.
This PR makes a checkmark appear on success. It is consistent with how the dashboard handles its Save button, where the spinner and checkmark also appear on success.
The width of the Apply button stays consistent when the spinner and checkmark are added or removed.