-
Notifications
You must be signed in to change notification settings - Fork 6
fixed broken link #474
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: stable
Are you sure you want to change the base?
fixed broken link #474
Conversation
WalkthroughA documentation file was updated to modify a hyperlink, changing the target from a URL without an extension to one with a Changes
Sequence Diagram(s)No sequence diagram generated as the change is limited to documentation hyperlink updates. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Deploying infrahub-sdk-python with
|
Latest commit: |
af0aa36
|
Status: | ✅ Deploy successful! |
Preview URL: | https://eefac9c9.infrahub-sdk-python.pages.dev |
Branch Preview URL: | https://doc-broken-link.infrahub-sdk-python.pages.dev |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
docs/docs/python-sdk/guides/resource-manager.mdx (1)
183-183
: Prefer a relative link over a hard-coded GitHub URLHard-coding the full GitHub path ties the docs to one repo location and breaks in offline or versioned site builds. A relative link keeps everything within the Docusaurus routing and is easier to maintain.
-[generators](https://github.com/opsmill/infrahub-docs/blob/main/docs/docs/topics/generator.mdx) +[generators](/docs/topics/generator)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
docs/docs/python-sdk/guides/resource-manager.mdx
(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: Cloudflare Pages
🔇 Additional comments (1)
docs/docs/python-sdk/guides/resource-manager.mdx (1)
183-183
: Fixed broken link – looks goodAdding the
.mdx
extension removes the 404 and restores navigation. Nice catch!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @vsurresh
I think the link should be https://docs.infrahub.app/topics/generator
instead
Not sure why we are pointing at the Github repository but this looks wrong to me.
The 'generators' link is missing the extension, so clicking the link from the doc results in a broken page. Quick fix.
Summary by CodeRabbit