Skip to content

IHS-176: Remove is_visible property from attribute metadata #603

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

IHS-176: Remove is_visible property from attribute metadata #603

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion infrahub_sdk/node/attribute.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,6 @@ def __init__(self, name: str, schema: AttributeSchemaAPI, data: Any | dict):
self.is_inherited: bool | None = data.get("is_inherited", None)
self.updated_at: str | None = data.get("updated_at", None)

self.is_visible: bool | None = data.get("is_visible", None)
self.is_protected: bool | None = data.get("is_protected", None)

self.source: NodeProperty | None = None
Expand Down
2 changes: 1 addition & 1 deletion infrahub_sdk/node/constants.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
import re
from typing import Union

PROPERTIES_FLAG = ["is_visible", "is_protected"]
PROPERTIES_FLAG = ["is_protected"]
PROPERTIES_OBJECT = ["source", "owner"]
SAFE_VALUE = re.compile(r"(^[\. /:a-zA-Z0-9_-]+$)|(^$)")

Expand Down
1 change: 0 additions & 1 deletion infrahub_sdk/protocols_base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,6 @@ class Attribute(Protocol):
is_from_profile: bool | None
is_inherited: bool | None
updated_at: str | None
is_visible: bool | None
is_protected: bool | None


Expand Down
3 changes: 0 additions & 3 deletions infrahub_sdk/schema/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,7 +135,6 @@ def generate_payload_create(
source: str | None = None,
owner: str | None = None,
is_protected: bool | None = None,
is_visible: bool | None = None,
) -> dict[str, Any]:
obj_data: dict[str, Any] = {}
item_metadata: dict[str, Any] = {}
Expand All @@ -145,8 +144,6 @@ def generate_payload_create(
item_metadata["owner"] = str(owner)
if is_protected is not None:
item_metadata["is_protected"] = is_protected
if is_visible is not None:
item_metadata["is_visible"] = is_visible

for key, value in data.items():
obj_data[key] = {}
Expand Down
Loading