fix(backend): various database session fixes #6309
Draft
+31
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Fatih Acar <[email protected]>
…onstraint runner Signed-off-by: Fatih Acar <[email protected]>
Signed-off-by: Fatih Acar <[email protected]>
github-actions
bot
added
the
group/backend
CodSpeed Performance ReportMerging #6309 will not alter performanceComparing Summary
|
dgarros
reviewed
Apr 16, 2025
| await relationship_manager.fetch_relationship_ids(db=db, force_refresh=True) | ||
| for relationship_constraint in self.relationship_manager_constraints: | ||
| await relationship_constraint.check(relm=relationship_manager, node_schema=node.get_schema()) | ||
| if not self.db.is_transaction: |
There was a problem hiding this comment.
We need to be careful here, as far as I remember one of the reason we are starting a new session is that otherwise we can't use the parallel runtime to check the uniqueness constraint and it will impact performance
I could be wrong here, I need to look deeper in the code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.