Update date display to include year and fix consistency across list and details views #6405
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pa-lem
added
type/bug
pa-lem
changed the title
pa-lem
changed the title
bilalabbad
reviewed
May 6, 2025
Comment on lines
+27
to
+29
| <span className="truncate"> | ||
| <DateDisplay date={attributeData.value} /> | ||
| </span> |
There was a problem hiding this comment.
Why should we not display time anymore?
There was a problem hiding this comment.
the goal is to make it consistent, it's a request from CS
There was a problem hiding this comment.
and there was no details in the previous format, with the component it will be more clear since we have the tooltip for the absolute value and it adapts depending on how old the date is
bilalabbad
approved these changes
May 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Format is:
d MMMfor the current yeard MMM yyyybeforeThe tooltip with absolute value is still available on hover