Skip to content

Update pre-commit hooks and fix mypy issues #601

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jul 7, 2025

Conversation

pre-commit-ci[bot]
Copy link
Contributor

@pre-commit-ci pre-commit-ci bot commented Jun 2, 2025

updates:

Notes

  • I downgraded the mirrors-mypy pre-commit hook to v1.14.1, to be aligned with the mypy version we use in the conda environment
  • I made some minor adjustments to the code to satisfy mypy
  • I removed the pointer to the pyproject.toml config file in the mypy pre-commit hook, since this should be chosen by default anyways

updates:
- [github.com/PyCQA/docformatter: eb1df34 → v1.7.7](PyCQA/docformatter@eb1df34...v1.7.7)
- [github.com/astral-sh/ruff-pre-commit: v0.11.8 → v0.11.12](astral-sh/ruff-pre-commit@v0.11.8...v0.11.12)
- [github.com/pre-commit/mirrors-mypy: v1.15.0 → v1.16.0](pre-commit/mirrors-mypy@v1.15.0...v1.16.0)
Copy link

codecov bot commented Jun 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Files with missing lines Coverage Δ
src/optimagic/deprecations.py 99.07% <100.00%> (ø)
src/optimagic/examples/criterion_functions.py 100.00% <100.00%> (ø)
src/optimagic/logging/logger.py 93.89% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@timmens
Copy link
Member

timmens commented Jul 6, 2025

mypy seems to be running smoothly when being called directly.

When being called through pre-commit it works locally for me, but apparently there is an issue when running it via pre-commit.ci.

@timmens timmens changed the title [pre-commit.ci] pre-commit autoupdate Update pre-commit hooks and fix mypy issues Jul 7, 2025
@timmens timmens merged commit 2418032 into main Jul 7, 2025
22 checks passed
@timmens timmens deleted the pre-commit-ci-update-config branch July 7, 2025 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant