Skip to content
This repository was archived by the owner on Sep 28, 2023. It is now read-only.

refactor(react-sdk/js-web-sdk): fix various typos #24

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

wsmcnaughton
Copy link

This PR corrects the following typos:

  • "gaurantee" -> "guarantee"
  • "sucess" -> "success"
  • "userPromiseResovler" -> "userPromiseResolver"

It also updates the README to correctly list the latest version of the React SDK and JS Web SDK packages.

@wsmcnaughton
Copy link
Author

Looks like I don't have permission to request reviewers, so I'm tagging y'all here instead: @asaschachar @mikeng13 @jordangarcia

Thanks!

@mikeproeng37 mikeproeng37 requested a review from mjc1283 July 9, 2019 01:41
@mikeproeng37
Copy link

Thanks for your contribution. Would you mind signing the CLA form as stated in our Contributing guide please: https://github.com/optimizely/fullstack-labs/blob/master/CONTRIBUTING.md

@wsmcnaughton
Copy link
Author

Signed 🙂

Copy link

@mikeproeng37 mikeproeng37 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@wsmcnaughton
Copy link
Author

@mikeng13 Just wanted to follow up on the status of this PR. Are we waiting for @mjc1283 to approve this as well?

@mikeproeng37
Copy link

Yes sorry @NAUGHTYMC . I'm just need @mjc1283 to bless it as well 😄

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants