Skip to content

[FSSDK-11169] Implement Decision Service methods to handle CMAB #403

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Mat001
Copy link
Contributor

@Mat001 Mat001 commented May 5, 2025

Decision Service methods to handle CMAB

  • added experiment_cmab_service.go file with cmab supportig methods
  • additionally updated decision/entities.go and decision/reasons/reason.go

Added unit tests.

Jira ticket: https://jira.sso.episerver.net/browse/FSSDK-11169

@Mat001 Mat001 self-assigned this May 5, 2025
@Mat001 Mat001 changed the title [FSSDK-111169] Implement Decision Service methods to handle CMAB DRAFT [FSSDK-111169] Implement Decision Service methods to handle CMAB May 5, 2025
@Mat001 Mat001 force-pushed the mpirnovar-cmab-decisionservice-methods-fssdk-11169 branch from bccad3d to b8f9e9c Compare May 7, 2025 10:23
@Mat001 Mat001 marked this pull request as ready for review May 14, 2025 16:09
@Mat001 Mat001 requested review from Copilot and raju-opti May 14, 2025 16:09
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR implements support for CMAB decision making in the Decision Service by adding new CMAB methods, updating relevant entities and reasons, and integrating the CMAB service into the composite experiment service.

  • Added experiment_cmab_service.go with CMAB-related decision logic
  • Updated reason constants and entities to include CMAB support
  • Integrated CMAB decision service in the composite experiment service and added corresponding unit tests

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

Show a summary per file
File Description
pkg/decision/reasons/reason.go Added new constant CmabVariationAssigned for CMAB decisions
pkg/decision/experiment_cmab_service_test.go Introduced unit tests for various CMAB decision scenarios
pkg/decision/experiment_cmab_service.go Implemented the CMAB decision logic and error handling
pkg/decision/entities.go Updated entities to register the new Cmab Source
pkg/decision/composite_experiment_service.go Extended composite service to include CMAB service integration
Comments suppressed due to low confidence (1)

pkg/decision/reasons/reason.go:63

  • [nitpick] The string value for CmabVariationAssigned is inconsistent with the format of other reason constants. Consider using a consistent, human-readable format (e.g. "CMAB variation assigned") to improve clarity.
CmabVariationAssigned Reason = "cmab_variation_assigned"

@Mat001 Mat001 changed the title DRAFT [FSSDK-111169] Implement Decision Service methods to handle CMAB DRAFT [FSSDK-11169] Implement Decision Service methods to handle CMAB May 14, 2025
@Mat001 Mat001 changed the title DRAFT [FSSDK-11169] Implement Decision Service methods to handle CMAB [FSSDK-11169] Implement Decision Service methods to handle CMAB May 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant