Skip to content

[FSSDK-11635] remove duplicated fetch method, add cache wrapper #409

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 24, 2025

Conversation

Mat001
Copy link
Contributor

@Mat001 Mat001 commented Jun 18, 2025

  • remove duplicated retry logic from cmab_service.go, only keep retry in cmab_client
  • lru_cache file has been moved to own pkg.cache, that can break cache related to odp code, creating a cache wrapper such that all new code uses the new location in pkg/cache/cache.go and old odp code will stil be compatible and work with the old cache location.
  • added deprecation comment to the wrapper

All unit tests pass, unchanged.

Jira: https://jira.sso.episerver.net/browse/FSSDK-11635

@Mat001 Mat001 self-assigned this Jun 18, 2025
@Mat001 Mat001 requested a review from raju-opti June 18, 2025 22:20
@Mat001 Mat001 merged commit ba1eeff into master Jun 24, 2025
13 checks passed
@Mat001 Mat001 deleted the mpirnovar-fix-retry-and-cache-fssdk-11635 branch June 24, 2025 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants