[FSSDK-11559] Mpirnovar fix activate endpoint holdouts #431
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mat001
changed the title
Mat001
changed the title
This change exposes holdouts in the OptimizelyConfig API, allowing clients to retrieve holdout information via the config endpoint. Changes: - Added OptimizelyHoldout type with id, key, audiences, and variationsMap - Added Holdouts field to OptimizelyConfig struct - Added GetHoldoutList() method to ProjectConfig interface - Implemented getHoldouts() helper to convert holdout entities to OptimizelyHoldouts - Populated holdouts in NewOptimizelyConfig constructor This enables Agent and other clients to expose holdout configuration through their /config endpoints.
Mat001
force-pushed
the
mpirnovar-fix-activate-endpoint-holdouts
branch
from
2d2cab3 to
0cff19a
Compare
This test verifies that: - Holdouts field is present in OptimizelyConfig - Holdouts field is initialized as empty array when no holdouts exist - Holdouts field correctly marshals to JSON
Mat001
force-pushed
the
mpirnovar-fix-activate-endpoint-holdouts
branch
from
e999974 to
def69a1
Compare
Updated all MockProjectConfig implementations to include the GetHoldoutList() method required by the config.ProjectConfig interface: - pkg/cmab/service_test.go: Added GetHoldoutList() to MockProjectConfig - pkg/decision/evaluator/audience_evaluator_test.go: Added GetHoldoutList() to MockProjectConfig - pkg/client/fixtures_test.go: Added GetHoldoutList() and GetHoldoutsForFlag() to MockProjectConfig - pkg/config/static_manager_test.go: Updated test assertion to expect empty Holdouts array instead of nil This fixes compilation errors in CMAB and audience evaluator tests where the mock implementations were missing the new interface method.
The Holdouts field was not part of the original TDD requirements and is not present in JavaScript or C# SDKs. This field was causing FSC test failures. Agent doesn't need holdouts exposed in OptimizelyConfig because: - Decision logic (GetHoldoutsForFlag, GetHoldoutList) works internally - Agent's /v1/decide endpoint uses go-sdk's decision service which already handles holdouts from v2.3.0 - OptimizelyConfig is metadata, not for decision-making Changes: - Removed Holdouts field from OptimizelyConfig struct - Removed OptimizelyHoldout type - Removed getHoldouts() and getHoldoutAudiences() helper functions - Removed holdout-specific tests (TestOptlyConfigIncludesHoldouts, TestOptlyConfigWithHoldouts) - Updated TestStaticGetOptimizelyConfig to not expect Holdouts field The ProjectConfig interface methods (GetHoldoutList, GetHoldoutsForFlag) remain as they are required by TDD for internal decision logic. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
Contributor
Author
|
PR no longer relevant. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add pti config changes to go-sdk required to support holdouts in agent:
Implementation Details:
https://optimizely-ext.atlassian.net/browse/FSSDK-11559