[FSSDK-11448] Java Implementation: Add Experiment ID and Variation ID to Decision Notification #566
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… to Decision Notification
| @@ -97,9 +97,13 @@ public static ExperimentDecisionNotificationBuilder newExperimentDecisionNotific | |||
| public static class ExperimentDecisionNotificationBuilder { | |||
| public final static String EXPERIMENT_KEY = "experimentKey"; | |||
| public final static String VARIATION_KEY = "variationKey"; | |||
| public final static String EXPERIMENT_ID = "experimentId"; | |||
There was a problem hiding this comment.
I think this class is responsible for activate api and other stuff that are failing in FSC. The createOptimizelyDecision method uses FlagDecisionNotificationBuilder. This class needs to stay unchanged.
| decisionInfo.put(VARIATION_KEY, variation != null ? variation.getKey() : null); | ||
| decisionInfo.put(VARIATION_ID, variationId); |
| @@ -141,7 +155,9 @@ public DecisionNotification build() { | |||
|
|
|||
| decisionInfo = new HashMap<>(); | |||
| decisionInfo.put(EXPERIMENT_KEY, experimentKey); | |||
| decisionInfo.put(EXPERIMENT_ID, experimentId); | |||
| this.variationId = variationId; | ||
| return this; | ||
| } | ||
|
|
There was a problem hiding this comment.
Probably why FSC is getting null values as experiment_id and variation_id. Not needed.
|
|
||
| private String type; | ||
| private String experimentKey; | ||
| private String experimentId; | ||
| private String variationId; |
There was a problem hiding this comment.
these also are not needed
As the FSC is passing, go ahead to merge the PR. |
esrakartalOpt
deleted the
esra/FSSDK-11448_decision_notification_expId_varId
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
experimentIdandvariationIdto decision notificationTest plan
Issues